win8/delegate_execute/command_execute_impl.cc - Issue 71013004: Base: Remove Receive() from ScopedHandle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: win8/delegate_execute/command_execute_impl.cc

Issue 71013004: Base: Remove Receive() from ScopedHandle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix delegate_execute for google_chrome_build Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: win8/delegate_execute/command_execute_impl.cc

diff --git a/win8/delegate_execute/command_execute_impl.cc b/win8/delegate_execute/command_execute_impl.cc

index 5f6cc190d6b76481aee0ec714fc2a2b2ebc1065f..f52037b743bf44de272fce386ceb8e606d754735 100644

--- a/win8/delegate_execute/command_execute_impl.cc

+++ b/win8/delegate_execute/command_execute_impl.cc

@@ -487,12 +487,13 @@ HRESULT CommandExecuteImpl::LaunchDesktopChrome() {

AtlTrace("Formatted command line is %ls\n", command_line.c_str());

- base::win::ScopedProcessInformation proc_info;

+ PROCESS_INFORMATION temp_process_info = {};

BOOL ret = CreateProcess(chrome_exe_.value().c_str(),

const_cast<LPWSTR>(command_line.c_str()),

NULL, NULL, FALSE, 0, NULL, NULL, &start_info_,

- proc_info.Receive());

+ &temp_process_info);

if (ret) {

+ base::win::ScopedProcessInformation proc_info(temp_process_info);

AtlTrace("Process id is %d\n", proc_info.process_id());

AllowSetForegroundWindow(proc_info.process_id());

} else {

« no previous file with comments | « win8/delegate_execute/chrome_util.cc ('k') | win8/test/metro_registration_helper.cc » ('j') | no next file with comments »