Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 710123002: AXRoleDescription for html figure tag would be 'figure'. (Closed)

Created:
6 years, 1 month ago by shreeramk
Modified:
6 years, 1 month ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

AXRoleDescription for html figure tag would be 'figure'. According to latest editor's draft http://rawgit.com/w3c/html-api-map/master/index.html, AXRoleDescription for figure tag would be 'figure' and xml-roles on window would be 'figure'. Committed: https://crrev.com/49e72bb95644712a7f43ac54bf60f09675ffebbc Cr-Commit-Position: refs/heads/master@{#303690}

Patch Set 1 #

Patch Set 2 : rebasing #

Patch Set 3 : rebasing #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M content/app/strings/content_strings.grd View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/data/accessibility/figure.html View 1 chunk +3 lines, -2 lines 0 comments Download
M content/test/data/accessibility/figure-expected-mac.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/figure-expected-win.txt View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
shreeramk
avi@chromium.org: Please review changes in content_strings.grd @dmazzoni: PTAL. Thanks :)
6 years, 1 month ago (2014-11-10 19:15:41 UTC) #2
Avi (use Gerrit)
LGTM conditional on dmazzoni's happiness.
6 years, 1 month ago (2014-11-10 19:27:33 UTC) #3
dmazzoni
lgtm
6 years, 1 month ago (2014-11-11 06:38:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/710123002/20001
6 years, 1 month ago (2014-11-11 06:40:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/27774)
6 years, 1 month ago (2014-11-11 07:51:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/710123002/40001
6 years, 1 month ago (2014-11-11 15:34:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/710123002/60001
6 years, 1 month ago (2014-11-11 18:01:33 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-11-11 19:37:42 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 19:38:46 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/49e72bb95644712a7f43ac54bf60f09675ffebbc
Cr-Commit-Position: refs/heads/master@{#303690}

Powered by Google App Engine
This is Rietveld 408576698