Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: sky/engine/core/css/parser/CSSPropertyParser.cpp

Issue 710113003: Initial step of removing CSS zoom related properties. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/css/MediaValues.cpp ('k') | sky/engine/core/css/resolver/AnimatedStyleBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/css/parser/CSSPropertyParser.cpp
diff --git a/sky/engine/core/css/parser/CSSPropertyParser.cpp b/sky/engine/core/css/parser/CSSPropertyParser.cpp
index 6cbef6bdbe6ef933f2ce7fda0647351bcde1fa65..a38112608fc9d7ee1a954b2af1c67acbcee1f221 100644
--- a/sky/engine/core/css/parser/CSSPropertyParser.cpp
+++ b/sky/engine/core/css/parser/CSSPropertyParser.cpp
@@ -867,13 +867,6 @@ bool CSSPropertyParser::parseValue(CSSPropertyID propId, bool important)
ASSERT(RuntimeEnabledFeatures::css3TextDecorationsEnabled());
return parseTextUnderlinePosition(important);
- case CSSPropertyZoom: // normal | reset | document | <number> | <percentage> | inherit
- if (id == CSSValueNormal || id == CSSValueReset || id == CSSValueDocument)
- validPrimitive = true;
- else
- validPrimitive = (!id && validUnit(value, FNumber | FPercent | FNonNeg));
- break;
-
case CSSPropertySrc: // Only used within @font-face and @-webkit-filter, so cannot use inherit | initial or be !important. This is a list of urls or local references.
parsedValue = parseFontFaceSrc();
break;
@@ -1324,10 +1317,7 @@ bool CSSPropertyParser::parseValue(CSSPropertyID propId, bool important)
// Properties below are validated inside parseViewportProperty, because we
// check for parser state. We need to invalidate if someone adds them outside
// a @viewport rule.
- case CSSPropertyMaxZoom:
- case CSSPropertyMinZoom:
case CSSPropertyOrientation:
- case CSSPropertyUserZoom:
validPrimitive = false;
break;
@@ -6114,18 +6104,6 @@ bool CSSPropertyParser::parseViewportProperty(CSSPropertyID propId, bool importa
return parseViewportShorthand(propId, CSSPropertyMinWidth, CSSPropertyMaxWidth, important);
case CSSPropertyHeight:
return parseViewportShorthand(propId, CSSPropertyMinHeight, CSSPropertyMaxHeight, important);
- case CSSPropertyMinZoom: // auto | <number> | <percentage>
- case CSSPropertyMaxZoom:
- case CSSPropertyZoom:
- if (id == CSSValueAuto)
- validPrimitive = true;
- else
- validPrimitive = (!id && validUnit(value, FNumber | FPercent | FNonNeg));
- break;
- case CSSPropertyUserZoom: // zoom | fixed
- if (id == CSSValueZoom || id == CSSValueFixed)
- validPrimitive = true;
- break;
case CSSPropertyOrientation: // auto | portrait | landscape
if (id == CSSValueAuto || id == CSSValuePortrait || id == CSSValueLandscape)
validPrimitive = true;
« no previous file with comments | « sky/engine/core/css/MediaValues.cpp ('k') | sky/engine/core/css/resolver/AnimatedStyleBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698