Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Unified Diff: content/browser/renderer_host/video_capture_host.cc

Issue 7101001: move EventHandler out of VideoCaptureController to make VS2005 happy (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: use default constructor Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/video_capture_host.cc
===================================================================
--- content/browser/renderer_host/video_capture_host.cc (revision 87397)
+++ content/browser/renderer_host/video_capture_host.cc (working copy)
@@ -31,36 +31,35 @@
///////////////////////////////////////////////////////////////////////////////
-// Implements VideoCaptureController::EventHandler.
-void VideoCaptureHost::OnError(VideoCaptureController::ControllerId id) {
+// Implements VideoCaptureControllerEventHandler.
+void VideoCaptureHost::OnError(const VideoCaptureControllerID& id) {
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
- NewRunnableMethod(this, &VideoCaptureHost::DoHandleError, id.first,
- id.second));
+ NewRunnableMethod(this, &VideoCaptureHost::DoHandleError, id.routing_id,
+ id.device_id));
}
void VideoCaptureHost::OnBufferReady(
- VideoCaptureController::ControllerId id,
+ const VideoCaptureControllerID& id,
TransportDIB::Handle handle,
base::Time timestamp) {
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
- NewRunnableMethod(this, &VideoCaptureHost::DoSendFilledBuffer, id.first,
- id.second, handle, timestamp));
+ NewRunnableMethod(this, &VideoCaptureHost::DoSendFilledBuffer,
+ id.routing_id, id.device_id, handle, timestamp));
}
-void VideoCaptureHost::OnFrameInfo(VideoCaptureController::ControllerId id,
+void VideoCaptureHost::OnFrameInfo(const VideoCaptureControllerID& id,
int width,
int height,
int frame_per_second) {
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
- NewRunnableMethod(this, &VideoCaptureHost::DoSendFrameInfo, id.first,
- id.second, width, height, frame_per_second));
+ NewRunnableMethod(this, &VideoCaptureHost::DoSendFrameInfo, id.routing_id,
+ id.device_id, width, height, frame_per_second));
}
-void VideoCaptureHost::OnReadyToDelete(
- VideoCaptureController::ControllerId id) {
+void VideoCaptureHost::OnReadyToDelete(const VideoCaptureControllerID& id) {
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
NewRunnableMethod(this, &VideoCaptureHost::DoDeleteVideoCaptureController,
@@ -83,7 +82,7 @@
Send(new VideoCaptureMsg_StateChanged(routing_id, device_id,
media::VideoCapture::kError));
- VideoCaptureController::ControllerId id(routing_id, device_id);
+ VideoCaptureControllerID id(routing_id, device_id);
EntryMap::iterator it = entries_.find(id);
if (it != entries_.end()) {
VideoCaptureController* controller = it->second;
@@ -127,8 +126,7 @@
const media::VideoCaptureParams& params) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
- VideoCaptureController::ControllerId controller_id(msg.routing_id(),
- device_id);
+ VideoCaptureControllerID controller_id(msg.routing_id(), device_id);
DCHECK(entries_.find(controller_id) == entries_.end());
@@ -141,8 +139,7 @@
void VideoCaptureHost::OnStopCapture(const IPC::Message& msg, int device_id) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
- VideoCaptureController::ControllerId controller_id(msg.routing_id(),
- device_id);
+ VideoCaptureControllerID controller_id(msg.routing_id(), device_id);
EntryMap::iterator it = entries_.find(controller_id);
if (it != entries_.end()) {
scoped_refptr<VideoCaptureController> controller = it->second;
@@ -166,8 +163,7 @@
TransportDIB::Handle handle) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
- VideoCaptureController::ControllerId controller_id(msg.routing_id(),
- device_id);
+ VideoCaptureControllerID controller_id(msg.routing_id(), device_id);
EntryMap::iterator it = entries_.find(controller_id);
if (it != entries_.end()) {
scoped_refptr<VideoCaptureController> controller = it->second;
@@ -176,11 +172,11 @@
}
void VideoCaptureHost::DoDeleteVideoCaptureController(
- VideoCaptureController::ControllerId id) {
+ const VideoCaptureControllerID& id) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
// Report that the device have successfully been stopped.
- Send(new VideoCaptureMsg_StateChanged(id.first, id.second,
+ Send(new VideoCaptureMsg_StateChanged(id.routing_id, id.device_id,
media::VideoCapture::kStopped));
entries_.erase(id);
}
« no previous file with comments | « content/browser/renderer_host/video_capture_host.h ('k') | content/browser/renderer_host/video_capture_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698