Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: content/browser/renderer_host/video_capture_controller.h

Issue 7101001: move EventHandler out of VideoCaptureController to make VS2005 happy (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: use default constructor Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/video_capture_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/video_capture_controller.h
===================================================================
--- content/browser/renderer_host/video_capture_controller.h (revision 87397)
+++ content/browser/renderer_host/video_capture_controller.h (working copy)
@@ -22,6 +22,7 @@
#include "base/process.h"
#include "base/synchronization/lock.h"
#include "base/task.h"
+#include "content/browser/renderer_host/video_capture_controller_event_handler.h"
#include "media/video/capture/video_capture_device.h"
#include "media/video/capture/video_capture_types.h"
#include "ui/gfx/surface/transport_dib.h"
@@ -30,51 +31,27 @@
: public base::RefCountedThreadSafe<VideoCaptureController>,
public media::VideoCaptureDevice::EventHandler {
public:
- // Id used for identifying an object of VideoCaptureController.
- typedef std::pair<int32, int> ControllerId;
- class EventHandler {
- public:
- // An Error have occurred in the VideoCaptureDevice.
- virtual void OnError(ControllerId id) = 0;
-
- // An TransportDIB have been filled with I420 video.
- virtual void OnBufferReady(ControllerId id,
- TransportDIB::Handle handle,
- base::Time timestamp) = 0;
-
- // The frame resolution the VideoCaptureDevice capture video in.
- virtual void OnFrameInfo(ControllerId id,
- int width,
- int height,
- int frame_rate) = 0;
-
- // Report that this object can be deleted.
- virtual void OnReadyToDelete(ControllerId id) = 0;
-
- protected:
- virtual ~EventHandler() {}
- };
-
- VideoCaptureController(ControllerId id,
+ VideoCaptureController(const VideoCaptureControllerID& id,
base::ProcessHandle render_process,
- EventHandler* event_handler);
+ VideoCaptureControllerEventHandler* event_handler);
virtual ~VideoCaptureController();
// Starts video capturing and tries to use the resolution specified in
// params.
- // When capturing has started EventHandler::OnFrameInfo is called with
- // resolution that best matches the requested that the video capture device
- // support.
+ // When capturing has started VideoCaptureControllerEventHandler::OnFrameInfo
+ // is called with resolution that best matches the requested that the video
+ // capture device support.
void StartCapture(const media::VideoCaptureParams& params);
// Stop video capture.
// When the capture is stopped and all TransportDIBS have been returned
- // EventHandler::OnReadyToDelete will be called.
+ // VideoCaptureControllerEventHandler::OnReadyToDelete will be called.
// stopped_task may be null but it can be used to get a notification when the
// device is stopped.
void StopCapture(Task* stopped_task);
- // Return a DIB previously given in EventHandler::OnBufferReady.
+ // Return a DIB previously given in
+ // VideoCaptureControllerEventHandler::OnBufferReady.
void ReturnTransportDIB(TransportDIB::Handle handle);
// Implement media::VideoCaptureDevice::EventHandler.
@@ -101,13 +78,13 @@
// All DIBS created by this object.
DIBMap owned_dibs_;
- EventHandler* event_handler_;
+ VideoCaptureControllerEventHandler* event_handler_;
// The parameter that was requested when starting the capture device.
media::VideoCaptureParams params_;
- // Id used for identifying this object.
- ControllerId id_;
+ // ID used for identifying this object.
+ VideoCaptureControllerID id_;
media::VideoCaptureDevice::Capability frame_info_;
DISALLOW_IMPLICIT_CONSTRUCTORS(VideoCaptureController);
« no previous file with comments | « no previous file | content/browser/renderer_host/video_capture_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698