codereview.settings - Issue 710093005: appengine: throw AssetErrors directly (instead of via new Future.error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: codereview.settings

Issue 710093005: appengine: throw AssetErrors directly (instead of via new Future.error (Closed) Base URL: https://github.com/dart-lang/appengine.git@master

Patch Set: nits Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: codereview.settings

diff --git a/codereview.settings b/codereview.settings

index 6b7c9862b6b6d4fa17b6079f948965caa05d2fb0..9eb32111d1e343ed9ae49a15b60841bf95cff396 100644

--- a/codereview.settings

+++ b/codereview.settings

@@ -1,3 +1,3 @@

-CODE_REVIEW_SERVER: https://chromereviews.googleplex.com

+CODE_REVIEW_SERVER: http://codereview.chromium.org/

VIEW_VC: https://github.com/dart-lang/appengine/commit/

-CC_LIST: prometheus-dart-reviews@google.com

+CC_LIST: prometheus-dart-reviews@google.com, reviews@dartlang.org

« no previous file with comments | « no previous file | lib/src/server/assets.dart » ('j') | no next file with comments »