Chromium Code Reviews| Index: tests/standalone/io/code_collection_test.dart |
| =================================================================== |
| --- tests/standalone/io/code_collection_test.dart (revision 41495) |
| +++ tests/standalone/io/code_collection_test.dart (working copy) |
| @@ -23,8 +23,9 @@ |
| doTest() { |
| - var i = 0; |
| - foo(1); // Initial call to compile. |
| + var i = 0; |
| + var ret = foo(1); // Initial call to compile. |
| + print("foo=$ret"); |
| // Time passes, GC runs, foo's code is dropped. |
| var ms = const Duration(milliseconds: 100); |
| var t = new Timer.periodic(ms, (timer) { |
| @@ -34,7 +35,8 @@ |
| timer.cancel(); |
| // foo is called again to make sure we can still run it even after |
| // its code has been detached. |
| - foo(2); |
| + var ret = foo(2); |
| + print("foo=$ret"); |
| } |
| }); |
| } |
| @@ -47,7 +49,7 @@ |
| // Run the test and capture stdout. |
| var pr = Process.runSync(Platform.executable, |
| ["--collect-code", |
| - "--code-collection-interval-in-us=100000", |
| + "--code-collection-interval-in-us=0", |
| "--old_gen_growth_rate=10", |
| "--log-code-drop", |
| "--optimization-counter-threshold=-1", |
| @@ -55,14 +57,22 @@ |
| Platform.script.toFilePath(), |
| "--run"]); |
| + Expect.equals(0, pr.exitCode); |
| + |
| // Code drops are logged with --log-code-drop. Look through stdout for the |
| // message that foo's code was dropped. |
| - var found = false; |
| + var count = 0; |
| pr.stdout.split("\n").forEach((line) { |
| if (line.contains("Detaching code") && line.contains("foo")) { |
| - found = true; |
| + count++; |
| } |
| + if (line.contains("foo=2")) { |
| + count++; |
| + } |
| + if (line.contains("foo=3")) { |
| + count++; |
| + } |
| }); |
| - Expect.isTrue(found); |
| + Expect.equals(3, count); |
|
Ivan Posva
2014/11/10 16:47:33
This test does not ensure that the code was detach
zra
2014/11/10 16:52:13
Acknowledged.
|
| } |
| } |