Report what went wrong when initializing NSS_NoDB_Init.

Report what went wrong when initializing NSS_NoDB_Init.

BUG=9857
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13602

[Dean McNamee, 2009-04-12 09:27:21]

LG

http://codereview.chromium.org/71009/diff/1/2
File base/nss_init.cc (right):

http://codereview.chromium.org/71009/diff/1/2#newcode48
Line 48: PRInt32 err_length = PR_GetErrorTextLength();
The length includes space for the NULL byte?

http://codereview.chromium.org/71009/diff/1/2#newcode51
Line 51: }
don't need { }, but it's ok.

[Elliot Glaysher, 2009-04-13 17:34:42]

http://codereview.chromium.org/71009/diff/1/2
File base/nss_init.cc (right):

http://codereview.chromium.org/71009/diff/1/2#newcode48
Line 48: PRInt32 err_length = PR_GetErrorTextLength();
On 2009/04/12 09:27:21, Dean McNamee wrote:
> The length includes space for the NULL byte?

Yes. The docs say "the value returned is sufficient to contain the error text
currently available," and all instances of the function on the first page of a
code search for the function don't add 1 for the NULL. (Most instances are in
Mozilla code, so I assume they know what they're doing.)

http://google.com/codesearch?q=PR_GetErrorTextLength&hl=en&btnG=Search+Code

http://codereview.chromium.org/71009/diff/1/2#newcode51
Line 51: }
On 2009/04/12 09:27:21, Dean McNamee wrote:
> don't need { }, but it's ok.

Done.