sync/internal_api/attachments/fake_attachment_uploader_unittest.cc - Issue 710073003: Store attachment crc in AttachmentStore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/attachments/fake_attachment_uploader_unittest.cc

Issue 710073003: Store attachment crc in AttachmentStore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/attachments/fake_attachment_uploader_unittest.cc

diff --git a/sync/internal_api/attachments/fake_attachment_uploader_unittest.cc b/sync/internal_api/attachments/fake_attachment_uploader_unittest.cc

index 2cfd75ece89d2ab383db886e0a102d803b6809f3..4ecbc7466a99fec0040aaa66bb0d051c436d2114 100644

--- a/sync/internal_api/attachments/fake_attachment_uploader_unittest.cc

+++ b/sync/internal_api/attachments/fake_attachment_uploader_unittest.cc

@@ -47,9 +47,9 @@ class FakeAttachmentUploaderTest : public testing::Test {

TEST_F(FakeAttachmentUploaderTest, UploadAttachment) {

scoped_refptr<base::RefCountedString> some_data(new base::RefCountedString);

some_data->data() = kAttachmentData;

- Attachment attachment1 = Attachment::Create(some_data);

- Attachment attachment2 = Attachment::Create(some_data);

- Attachment attachment3 = Attachment::Create(some_data);

+ Attachment attachment1 = Attachment::CreateNew(some_data);

+ Attachment attachment2 = Attachment::CreateNew(some_data);

+ Attachment attachment3 = Attachment::CreateNew(some_data);

uploader.UploadAttachment(attachment1, upload_callback);

uploader.UploadAttachment(attachment2, upload_callback);

uploader.UploadAttachment(attachment3, upload_callback);