Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Side by Side Diff: sync/api/attachments/attachment_unittest.cc

Issue 710073003: Store attachment crc in AttachmentStore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Add comment in attachment_util.h. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/api/attachments/attachment.h" 5 #include "sync/api/attachments/attachment.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/memory/ref_counted_memory.h" 10 #include "base/memory/ref_counted_memory.h"
11 #include "sync/internal_api/public/attachments/attachment_util.h"
11 #include "sync/protocol/sync.pb.h" 12 #include "sync/protocol/sync.pb.h"
12 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
13 14
14 namespace syncer { 15 namespace syncer {
15 16
16 namespace { 17 namespace {
17 18
18 const char kAttachmentData[] = "some data"; 19 const char kAttachmentData[] = "some data";
19 20
20 } // namespace 21 } // namespace
21 22
22 class AttachmentTest : public testing::Test {}; 23 class AttachmentTest : public testing::Test {};
23 24
24 TEST_F(AttachmentTest, Create_UniqueIdIsUnique) { 25 TEST_F(AttachmentTest, Create_UniqueIdIsUnique) {
25 scoped_refptr<base::RefCountedString> some_data(new base::RefCountedString); 26 scoped_refptr<base::RefCountedString> some_data(new base::RefCountedString);
26 some_data->data() = kAttachmentData; 27 some_data->data() = kAttachmentData;
27 Attachment a1 = Attachment::Create(some_data); 28 Attachment a1 = Attachment::Create(some_data);
28 Attachment a2 = Attachment::Create(some_data); 29 Attachment a2 = Attachment::Create(some_data);
29 EXPECT_NE(a1.GetId(), a2.GetId()); 30 EXPECT_NE(a1.GetId(), a2.GetId());
30 EXPECT_EQ(a1.GetData(), a2.GetData()); 31 EXPECT_EQ(a1.GetData(), a2.GetData());
31 } 32 }
32 33
33 TEST_F(AttachmentTest, Create_WithEmptyData) { 34 TEST_F(AttachmentTest, Create_WithEmptyData) {
34 scoped_refptr<base::RefCountedString> empty_data(new base::RefCountedString); 35 scoped_refptr<base::RefCountedString> empty_data(new base::RefCountedString);
35 Attachment a = Attachment::Create(empty_data); 36 Attachment a = Attachment::Create(empty_data);
36 EXPECT_EQ(empty_data, a.GetData()); 37 EXPECT_EQ(empty_data, a.GetData());
37 } 38 }
38 39
39 TEST_F(AttachmentTest, CreateWithId_HappyCase) { 40 TEST_F(AttachmentTest, CreateFromParts_HappyCase) {
40 AttachmentId id = AttachmentId::Create(); 41 AttachmentId id = AttachmentId::Create();
41 scoped_refptr<base::RefCountedString> some_data(new base::RefCountedString); 42 scoped_refptr<base::RefCountedString> some_data(new base::RefCountedString);
42 some_data->data() = kAttachmentData; 43 some_data->data() = kAttachmentData;
43 Attachment a = Attachment::CreateWithId(id, some_data); 44 uint32_t crc32c = ComputeCrc32c(some_data);
45 Attachment a = Attachment::CreateFromParts(id, some_data, crc32c);
44 EXPECT_EQ(id, a.GetId()); 46 EXPECT_EQ(id, a.GetId());
45 EXPECT_EQ(some_data, a.GetData()); 47 EXPECT_EQ(some_data, a.GetData());
46 } 48 }
47 49
48 } // namespace syncer 50 } // namespace syncer
OLDNEW
« no previous file with comments | « sync/api/attachments/attachment.cc ('k') | sync/internal_api/attachments/attachment_downloader_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698