Store attachment crc in AttachmentStore

sync/internal_api/attachments/attachment_downloader_impl_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/internal_api/public/attachments/attachment_downloader_impl.h"
 
 #include "base/bind.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/thread_task_runner_handle.h"
 #include "google_apis/gaia/fake_oauth2_token_service.h"
 #include "google_apis/gaia/gaia_constants.h"
 #include "net/http/http_response_headers.h"
 #include "net/url_request/test_url_fetcher_factory.h"
 #include "net/url_request/url_request_test_util.h"
 #include "sync/api/attachments/attachment.h"
 #include "sync/internal_api/public/attachments/attachment_uploader_impl.h"
+#include "sync/internal_api/public/attachments/attachment_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/leveldatabase/src/util/crc32c.h"
 
 namespace syncer {
 
 namespace {
 
 const char kAccountId[] = "attachments@gmail.com";
 const char kAccessToken[] = "access.token";
 const char kAttachmentServerUrl[] = "http://attachments.com/";
 const char kAttachmentContent[] = "attachment.content";
 
@@ skipping 241 matching lines @@
 void AttachmentDownloaderImplTest::AddHashHeader(
     HashHeaderType hash_header_type,
     net::TestURLFetcher* fetcher) {
   std::string header = "X-Goog-Hash: crc32c=";
   scoped_refptr<net::HttpResponseHeaders> headers(
       new net::HttpResponseHeaders(""));
   switch (hash_header_type) {
     case HASH_HEADER_NONE:
       break;
     case HASH_HEADER_VALID:
-      header += AttachmentUploaderImpl::ComputeCrc32cHash(
-          kAttachmentContent, strlen(kAttachmentContent));
+      header += AttachmentUploaderImpl::FormatCrc32cHash(leveldb::crc32c::Value(
+          kAttachmentContent, strlen(kAttachmentContent)));
       headers->AddHeader(header);
       break;
     case HASH_HEADER_INVALID:
       header += "BOGUS1==";
       headers->AddHeader(header);
       break;
   }
   fetcher->set_response_headers(headers);
 }
 
@@ skipping 119 matching lines @@
   AttachmentId id1 = AttachmentId::Create();
   downloader()->DownloadAttachment(id1, download_callback(id1));
   RunMessageLoop();
   token_service()->RespondToAccessTokenRequest(
       GoogleServiceAuthError::AuthErrorNone());
   RunMessageLoop();
   CompleteDownload(net::HTTP_OK, HASH_HEADER_INVALID);
   VerifyDownloadResult(id1, AttachmentDownloader::DOWNLOAD_TRANSIENT_ERROR);
 }
 
+// Verify that extract fails when there is no headers object.
+TEST_F(AttachmentDownloaderImplTest, ExtractCrc32c_NoHeaders) {
+  uint32_t extracted;
+  ASSERT_FALSE(AttachmentDownloaderImpl::ExtractCrc32c(nullptr, &extracted));
+}
 
 // Verify that extract fails when there is no crc32c value.
 TEST_F(AttachmentDownloaderImplTest, ExtractCrc32c_Empty) {
   std::string raw;
   raw += "HTTP/1.1 200 OK\n";
   raw += "Foo: bar\n";
   raw += "X-Goog-HASH: crc32c=\n";
   raw += "\n";
   std::replace(raw.begin(), raw.end(), '\n', '\0');
   scoped_refptr<net::HttpResponseHeaders> headers(
       new net::HttpResponseHeaders(raw));
-  std::string extracted;
-  ASSERT_FALSE(AttachmentDownloaderImpl::ExtractCrc32c(*headers, &extracted));
+  uint32_t extracted;
+  ASSERT_FALSE(
+      AttachmentDownloaderImpl::ExtractCrc32c(headers.get(), &extracted));
 }
 
 // Verify that extract finds the first crc32c and ignores others.
 TEST_F(AttachmentDownloaderImplTest, ExtractCrc32c_First) {
-  const std::string expected = "z8SuHQ==";
+  const std::string expected_encoded = "z8SuHQ==";
+  const uint32_t expected = 3485773341;
   std::string raw;
   raw += "HTTP/1.1 200 OK\n";
   raw += "Foo: bar\n";
   // Ignored because it's the wrong header.
   raw += "X-Goog-Hashes: crc32c=AAAAAA==\n";
   // Header name matches.  The md5 item is ignored.
-  raw += "X-Goog-HASH: md5=rL0Y20zC+Fzt72VPzMSk2A==,crc32c=" + expected + "\n";
+  raw += "X-Goog-HASH: md5=rL0Y20zC+Fzt72VPzMSk2A==,crc32c=" +
+         expected_encoded + "\n";
   // Ignored because we already found a crc32c in the one above.
   raw += "X-Goog-HASH: crc32c=AAAAAA==\n";
   raw += "\n";
   std::replace(raw.begin(), raw.end(), '\n', '\0');
   scoped_refptr<net::HttpResponseHeaders> headers(
       new net::HttpResponseHeaders(raw));
-  std::string extracted;
-  ASSERT_TRUE(AttachmentDownloaderImpl::ExtractCrc32c(*headers, &extracted));
+  uint32_t extracted;
+  ASSERT_TRUE(
+      AttachmentDownloaderImpl::ExtractCrc32c(headers.get(), &extracted));
   ASSERT_EQ(expected, extracted);
 }
 
+// Verify that extract fails when encoded value is too long.
+TEST_F(AttachmentDownloaderImplTest, ExtractCrc32c_TooLong) {

[maniscalco, 2014/11/11 00:44:54]

Good one!

+  std::string raw;
+  raw += "HTTP/1.1 200 OK\n";
+  raw += "Foo: bar\n";
+  raw += "X-Goog-HASH: crc32c=AAAAAAAA\n";
+  raw += "\n";
+  std::replace(raw.begin(), raw.end(), '\n', '\0');
+  scoped_refptr<net::HttpResponseHeaders> headers(
+      new net::HttpResponseHeaders(raw));
+  uint32_t extracted;
+  ASSERT_FALSE(
+      AttachmentDownloaderImpl::ExtractCrc32c(headers.get(), &extracted));
+}
+
 // Verify that extract fails if there is no crc32c.
 TEST_F(AttachmentDownloaderImplTest, ExtractCrc32c_None) {
   std::string raw;
   raw += "HTTP/1.1 200 OK\n";
   raw += "Foo: bar\n";
   raw += "X-Goog-Hash: md5=rL0Y20zC+Fzt72VPzMSk2A==\n";
   raw += "\n";
   std::replace(raw.begin(), raw.end(), '\n', '\0');
   scoped_refptr<net::HttpResponseHeaders> headers(
       new net::HttpResponseHeaders(raw));
-  std::string extracted;
-  ASSERT_FALSE(AttachmentDownloaderImpl::ExtractCrc32c(*headers, &extracted));
+  uint32_t extracted;
+  ASSERT_FALSE(
+      AttachmentDownloaderImpl::ExtractCrc32c(headers.get(), &extracted));
 }
 
 }  // namespace syncer