Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1635)

Unified Diff: mojo/services/window_manager/window_manager_app.cc

Issue 710043004: Make it possible to have multiple InspectorBackends (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Split out ServerImpl, somehow breaks JS connections... Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/window_manager/window_manager_app.cc
diff --git a/mojo/services/window_manager/window_manager_app.cc b/mojo/services/window_manager/window_manager_app.cc
index 2ba436a291a4bb42f41e83d83b71e734b79d6add..d6a2416b8988805ce82e49e92331708e3474b1c6 100644
--- a/mojo/services/window_manager/window_manager_app.cc
+++ b/mojo/services/window_manager/window_manager_app.cc
@@ -96,6 +96,7 @@ class WindowManagerApp::WindowManagerInternalImpl
// InterfaceImpl:
void OnConnectionError() override {
// Necessary since we used WeakBindToPipe and are not automatically deleted.
+ // crbug.com/431911
delete this;
}
« no previous file with comments | « no previous file | sky/framework/inspector/inspector.sky » ('j') | sky/services/inspector/inspector_frontend_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698