Make it possible to have multiple InspectorBackends

sky/services/inspector/inspector_frontend_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SKY_SERVICES_INSPECTOR_INSPECTOR_FRONTEND_IMPL_H_
 #define SKY_SERVICES_INSPECTOR_INSPECTOR_FRONTEND_IMPL_H_
 
 #include "mojo/public/cpp/application/interface_factory_impl.h"
 #include "mojo/public/cpp/bindings/interface_impl.h"
 #include "net/server/http_server.h"
 #include "net/socket/tcp_server_socket.h"
 #include "sky/services/inspector/inspector.mojom.h"
 
 namespace sky {
 namespace inspector {
 
-class InspectorFrontendImpl : public mojo::InterfaceImpl<InspectorFrontend>,
-                             public net::HttpServer::Delegate {
+class InspectorFrontendImpl : public mojo::InterfaceImpl<InspectorFrontend> {

[Aaron Boodman, 2014/11/11 16:12:50]

I find that it makes implementation easier to put these InterfaceImpls in the
same cc file with the class you're forwarding to. For example, you wouldn't need
the delegate interface if you did that.

Anyway that's the convention that has been developing elsewhere.

  public:
-  InspectorFrontendImpl();
+  class Delegate {
+  public:
+    virtual void Register(InspectorFrontendImpl*) = 0;

[Aaron Boodman, 2014/11/11 16:12:50]

You can avoid the Register() function by just having the factory do the
registration on creation. One less boilerplate.

+    virtual void Unregister(InspectorFrontendImpl*) = 0;
+    virtual void SendMessage(const mojo::String&) = 0;
+  };
+
+  InspectorFrontendImpl(Delegate* delegate);

[abarth-chromium, 2014/11/11 02:53:57]

explicit

   virtual ~InspectorFrontendImpl();
 
+  void OnShutdown();
+
  private:
-  // From net::HttpServer::Delegate
-  virtual void OnConnect(int connection_id) override;
-  virtual void OnHttpRequest(
-      int connection_id, const net::HttpServerRequestInfo& info) override;
-  virtual void OnWebSocketRequest(
-      int connection_id, const net::HttpServerRequestInfo& info) override;
-  virtual void OnWebSocketMessage(
-      int connection_id, const std::string& data) override;
-  virtual void OnClose(int connection_id) override;
+  // InspectorFrontend:
+  void SendMessage(const mojo::String& message) override;
 
-  // From InspectorFrontend
-  virtual void Listen(int32_t port) override;
-  virtual void SendMessage(const mojo::String&) override;
+  // InterfaceImpl:
+  void OnConnectionError() override;
 
-  void StopListening();
-
-  void Register(int port);
-  void Unregister();
-
-  int port_;
-  int connection_id_;
-  scoped_ptr<net::HttpServer> web_server_;
+  Delegate* delegate_;
 
   MOJO_DISALLOW_COPY_AND_ASSIGN(InspectorFrontendImpl);
 };
 
-typedef mojo::InterfaceFactoryImpl<
-    InspectorFrontendImpl> InspectorFrontendFactory;
-
 }  // namespace tester
 }  // namespace sky
 
 #endif  // SKY_SERVICES_INSPECTOR_INSPECTOR_FRONTEND_IMPL_H_