Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 710033003: [DevTools] Extract part of DevTools into inspector app. (Closed)

Created:
6 years, 1 month ago by dgozman
Modified:
6 years, 1 month ago
Reviewers:
apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Extract part of DevTools into inspector app. This inspector app is intended to be run inside an iframe. InspectorAppHost exposes an API between inspector app and hosting app. Created DevTools app which is only embedding inspector app in iframe. Next patches will define API and move hosting functionality from inspector app to devtools app. BUG=431697 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185127

Patch Set 1 #

Total comments: 2

Patch Set 2 : Inlined iframe, test support #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -78 lines) Patch
M Source/devtools/BUILD.gn View 1 8 chunks +14 lines, -1 line 0 comments Download
M Source/devtools/devtools.gyp View 6 chunks +27 lines, -1 line 0 comments Download
M Source/devtools/devtools.gypi View 1 2 5 chunks +9 lines, -0 lines 0 comments Download
M Source/devtools/front_end/devtools.css View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/devtools/front_end/devtools.html View 1 1 chunk +6 lines, -2 lines 0 comments Download
M Source/devtools/front_end/devtools.json View 1 1 chunk +1 line, -27 lines 0 comments Download
A Source/devtools/front_end/devtools_app/DevToolsApp.js View 1 1 chunk +83 lines, -0 lines 0 comments Download
A + Source/devtools/front_end/devtools_app/module.json View 1 1 chunk +3 lines, -1 line 0 comments Download
A Source/devtools/front_end/host/InspectorAppHost.js View 1 chunk +37 lines, -0 lines 0 comments Download
M Source/devtools/front_end/host/InspectorFrontendHost.js View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/host/module.json View 1 chunk +2 lines, -1 line 0 comments Download
A + Source/devtools/front_end/inspector.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/devtools/front_end/inspector.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/devtools/front_end/inspector.js View 1 chunk +1 line, -1 line 0 comments Download
A + Source/devtools/front_end/inspector.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/devtools/front_end/inspectorStyle.css View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/devtools/front_end/main/AdvancedApp.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 2 2 chunks +6 lines, -15 lines 0 comments Download
M Source/devtools/front_end/platform/DOMExtension.js View 1 1 chunk +21 lines, -0 lines 0 comments Download
M Source/devtools/front_end/toolbox_bootstrap/Toolbox.js View 1 chunk +1 line, -20 lines 0 comments Download
M Source/devtools/scripts/compile_frontend.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
dgozman
Take a look please.
6 years, 1 month ago (2014-11-10 12:45:59 UTC) #2
pfeldman
https://codereview.chromium.org/710033003/diff/1/Source/devtools/front_end/devtools_bootstrap/DevToolsApp.js File Source/devtools/front_end/devtools_bootstrap/DevToolsApp.js (right): https://codereview.chromium.org/710033003/diff/1/Source/devtools/front_end/devtools_bootstrap/DevToolsApp.js#newcode15 Source/devtools/front_end/devtools_bootstrap/DevToolsApp.js:15: WebInspector.addExtensions = this._wrapInvocation.bind(this, "addExtensions"); We should reverse the direction ...
6 years, 1 month ago (2014-11-10 15:48:36 UTC) #3
pfeldman
Please don't regress TTIE. Otherwise, lgtm
6 years, 1 month ago (2014-11-10 16:44:25 UTC) #4
dgozman
With document.write TTIE is not regressed by a lot. https://codereview.chromium.org/710033003/diff/1/Source/devtools/front_end/devtools_bootstrap/DevToolsApp.js File Source/devtools/front_end/devtools_bootstrap/DevToolsApp.js (right): https://codereview.chromium.org/710033003/diff/1/Source/devtools/front_end/devtools_bootstrap/DevToolsApp.js#newcode15 Source/devtools/front_end/devtools_bootstrap/DevToolsApp.js:15: ...
6 years, 1 month ago (2014-11-10 18:19:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/710033003/40001
6 years, 1 month ago (2014-11-11 14:34:21 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 15:45:45 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 185127

Powered by Google App Engine
This is Rietveld 408576698