chrome/browser/renderer_host/chrome_extension_message_filter.cc - Issue 709933002: Add frameId to MessageSender (extension messaging API)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/chrome_extension_message_filter.cc

Issue 709933002: Add frameId to MessageSender (extension messaging API) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test that tests for a non-negative frameId Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/messaging/message_service.cc ('K') | « chrome/browser/extensions/api/messaging/message_service.cc ('k') | chrome/test/data/extensions/api_test/messaging/connect/frame.js » ('j') | chrome/test/data/extensions/api_test/messaging/connect/page.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/chrome_extension_message_filter.cc

diff --git a/chrome/browser/renderer_host/chrome_extension_message_filter.cc b/chrome/browser/renderer_host/chrome_extension_message_filter.cc

index c0ab760f8c3cf4966e539df5f37ee8c3c5e7efb6..734dd2942edc3e5c89cdef99afa4a704182eb3b0 100644

--- a/chrome/browser/renderer_host/chrome_extension_message_filter.cc

+++ b/chrome/browser/renderer_host/chrome_extension_message_filter.cc

@@ -156,6 +156,7 @@ void ChromeExtensionMessageFilter::OpenChannelToExtensionOnUIThread(

->OpenChannelToExtension(source_process_id,

source_routing_id,

receiver_port_id,

+ info.source_frame_id,

info.source_id,

info.target_id,

info.source_url,