chrome/browser/extensions/api/messaging/extension_message_port.cc - Issue 709933002: Add frameId to MessageSender (extension messaging API)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/extension_message_port.cc

Issue 709933002: Add frameId to MessageSender (extension messaging API) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test that tests for a non-negative frameId Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/extension_message_port.h ('k') | chrome/browser/extensions/api/messaging/message_service.h » ('j') | chrome/browser/extensions/api/messaging/message_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/extension_message_port.cc

diff --git a/chrome/browser/extensions/api/messaging/extension_message_port.cc b/chrome/browser/extensions/api/messaging/extension_message_port.cc

index d5d0b1fd9a097b7955c1ee7bf71874f63ecb4dc5..a2305d1c9e6489a686883e7f77fdcacfbdd1c258 100644

--- a/chrome/browser/extensions/api/messaging/extension_message_port.cc

+++ b/chrome/browser/extensions/api/messaging/extension_message_port.cc

@@ -26,6 +26,7 @@ void ExtensionMessagePort::DispatchOnConnect(

int dest_port_id,

const std::string& channel_name,

const base::DictionaryValue& source_tab,

+ int source_frame_id,

const std::string& source_extension_id,

const std::string& target_extension_id,

const GURL& source_url,

@@ -33,6 +34,7 @@ void ExtensionMessagePort::DispatchOnConnect(

ExtensionMsg_ExternalConnectionInfo info;

info.target_id = target_extension_id;

info.source_id = source_extension_id;

+ info.source_frame_id = source_frame_id;

info.source_url = source_url;

process_->Send(new ExtensionMsg_DispatchOnConnect(

routing_id_, dest_port_id, channel_name, source_tab, info,