Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: extensions/renderer/extension_helper.cc

Issue 709933002: Add frameId to MessageSender (extension messaging API) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test: sender.tab.status = 'complete' Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/extension_helper.h ('k') | extensions/renderer/messaging_bindings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/extension_helper.cc
diff --git a/extensions/renderer/extension_helper.cc b/extensions/renderer/extension_helper.cc
index fef086948a3e113184db846b7f40a7f2e82e0f33..deba1ec8378418e4ecd4581c537f41e51268c5cc 100644
--- a/extensions/renderer/extension_helper.cc
+++ b/extensions/renderer/extension_helper.cc
@@ -6,13 +6,11 @@
#include "content/public/renderer/render_view.h"
#include "content/public/renderer/render_view_visitor.h"
-#include "extensions/common/api/messaging/message.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension_messages.h"
#include "extensions/renderer/api/automation/automation_api_helper.h"
#include "extensions/renderer/console.h"
#include "extensions/renderer/dispatcher.h"
-#include "extensions/renderer/messaging_bindings.h"
#include "third_party/WebKit/public/platform/WebURLRequest.h"
#include "third_party/WebKit/public/web/WebConsoleMessage.h"
#include "third_party/WebKit/public/web/WebDocument.h"
@@ -135,11 +133,6 @@ bool ExtensionHelper::OnMessageReceived(const IPC::Message& message) {
IPC_BEGIN_MESSAGE_MAP(ExtensionHelper, message)
IPC_MESSAGE_HANDLER(ExtensionMsg_Response, OnExtensionResponse)
IPC_MESSAGE_HANDLER(ExtensionMsg_MessageInvoke, OnExtensionMessageInvoke)
- IPC_MESSAGE_HANDLER(ExtensionMsg_DispatchOnConnect,
- OnExtensionDispatchOnConnect)
- IPC_MESSAGE_HANDLER(ExtensionMsg_DeliverMessage, OnExtensionDeliverMessage)
- IPC_MESSAGE_HANDLER(ExtensionMsg_DispatchOnDisconnect,
- OnExtensionDispatchOnDisconnect)
IPC_MESSAGE_HANDLER(ExtensionMsg_SetFrameName, OnSetFrameName)
IPC_MESSAGE_HANDLER(ExtensionMsg_SetTabId, OnSetTabId)
IPC_MESSAGE_HANDLER(ExtensionMsg_UpdateBrowserWindowId,
@@ -200,34 +193,6 @@ void ExtensionHelper::OnExtensionMessageInvoke(const std::string& extension_id,
user_gesture);
}
-void ExtensionHelper::OnExtensionDispatchOnConnect(
- int target_port_id,
- const std::string& channel_name,
- const base::DictionaryValue& source_tab,
- const ExtensionMsg_ExternalConnectionInfo& info,
- const std::string& tls_channel_id) {
- MessagingBindings::DispatchOnConnect(dispatcher_->script_context_set(),
- target_port_id,
- channel_name,
- source_tab,
- info,
- tls_channel_id,
- render_view());
-}
-
-void ExtensionHelper::OnExtensionDeliverMessage(int target_id,
- const Message& message) {
- MessagingBindings::DeliverMessage(
- dispatcher_->script_context_set(), target_id, message, render_view());
-}
-
-void ExtensionHelper::OnExtensionDispatchOnDisconnect(
- int port_id,
- const std::string& error_message) {
- MessagingBindings::DispatchOnDisconnect(
- dispatcher_->script_context_set(), port_id, error_message, render_view());
-}
-
void ExtensionHelper::OnNotifyRendererViewType(ViewType type) {
view_type_ = type;
}
« no previous file with comments | « extensions/renderer/extension_helper.h ('k') | extensions/renderer/messaging_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698