Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3059)

Unified Diff: chrome/browser/extensions/api/messaging/message_service.h

Issue 709933002: Add frameId to MessageSender (extension messaging API) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test: sender.tab.status = 'complete' Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/messaging/message_service.h
diff --git a/chrome/browser/extensions/api/messaging/message_service.h b/chrome/browser/extensions/api/messaging/message_service.h
index 6dcde00c9f86060846fa5c4145a157e25a1eaa60..59eea934444cec091badb4df1b849b98dc590a54 100644
--- a/chrome/browser/extensions/api/messaging/message_service.h
+++ b/chrome/browser/extensions/api/messaging/message_service.h
@@ -13,6 +13,7 @@
#include "base/compiler_specific.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
+#include "base/values.h"
#include "chrome/browser/extensions/api/messaging/message_property_provider.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
@@ -23,10 +24,6 @@
class GURL;
class Profile;
-namespace base {
-class DictionaryValue;
-}
-
namespace content {
class BrowserContext;
class RenderProcessHost;
@@ -74,7 +71,8 @@ class MessageService : public BrowserContextKeyedAPI,
// Notify the port that the channel has been opened.
virtual void DispatchOnConnect(int dest_port_id,
const std::string& channel_name,
- const base::DictionaryValue& source_tab,
+ scoped_ptr<base::DictionaryValue> source_tab,
+ int source_frame_id,
const std::string& source_extension_id,
const std::string& target_extension_id,
const GURL& source_url,

Powered by Google App Engine
This is Rietveld 408576698