chrome/browser/extensions/api/messaging/extension_message_port.h - Issue 709933002: Add frameId to MessageSender (extension messaging API)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/extension_message_port.h

Issue 709933002: Add frameId to MessageSender (extension messaging API) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test: sender.tab.status = 'complete' Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/messaging/extension_message_port.h

diff --git a/chrome/browser/extensions/api/messaging/extension_message_port.h b/chrome/browser/extensions/api/messaging/extension_message_port.h

index f427e23da5f5fc827341b9c042c5b44c36506380..a7b7328f63da64e30df371a8f8375b9b93649f6d 100644

--- a/chrome/browser/extensions/api/messaging/extension_message_port.h

+++ b/chrome/browser/extensions/api/messaging/extension_message_port.h

@@ -23,7 +23,8 @@ class ExtensionMessagePort : public MessageService::MessagePort {

const std::string& extension_id);

void DispatchOnConnect(int dest_port_id,

const std::string& channel_name,

- const base::DictionaryValue& source_tab,

+ scoped_ptr<base::DictionaryValue> source_tab,

+ int source_frame_id,

const std::string& source_extension_id,

const std::string& target_extension_id,

const GURL& source_url,

« no previous file with comments | « no previous file | chrome/browser/extensions/api/messaging/extension_message_port.cc » ('j') | no next file with comments »