extensions/renderer/resources/messaging.js - Issue 709933002: Add frameId to MessageSender (extension messaging API)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/messaging.js

Issue 709933002: Add frameId to MessageSender (extension messaging API) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: User scoped_ptr instead of ref, refactor test Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/resources/messaging.js

diff --git a/extensions/renderer/resources/messaging.js b/extensions/renderer/resources/messaging.js

index 5a83654c501357ad0b0a8c6578aa464076eb3fe8..d0491c01b95adc4752d757fe3f6893a8aebd5b02 100644

--- a/extensions/renderer/resources/messaging.js

+++ b/extensions/renderer/resources/messaging.js

@@ -216,6 +216,7 @@

function dispatchOnConnect(portId,

channelName,

sourceTab,

+ sourceFrameId,

sourceExtensionId,

targetExtensionId,

sourceUrl,

@@ -244,6 +245,8 @@

sender.url = sourceUrl;

if (sourceTab)

sender.tab = sourceTab;

+ if (sourceFrameId >= 0)

+ sender.frameId = sourceFrameId;

if (tlsChannelId !== undefined)

sender.tlsChannelId = tlsChannelId;

« chrome/test/data/extensions/api_test/messaging/connect/test.js ('K') | « extensions/renderer/messaging_bindings.cc ('k') | no next file » | no next file with comments »