extensions/renderer/messaging_bindings.h - Issue 709933002: Add frameId to MessageSender (extension messaging API)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/messaging_bindings.h

Issue 709933002: Add frameId to MessageSender (extension messaging API) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: User scoped_ptr instead of ref, refactor test Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/api_test/messaging/connect/test.js ('K') | « extensions/renderer/extension_helper.cc ('k') | extensions/renderer/messaging_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/messaging_bindings.h

diff --git a/extensions/renderer/messaging_bindings.h b/extensions/renderer/messaging_bindings.h

index 422dcae7ae9356f208f1cedea3471a3d7c142dda..cc1a7a50586465f2b64fd195329d1711058e5b61 100644

--- a/extensions/renderer/messaging_bindings.h

+++ b/extensions/renderer/messaging_bindings.h

@@ -10,6 +10,7 @@

#include "extensions/renderer/script_context_set.h"

struct ExtensionMsg_ExternalConnectionInfo;

+struct ExtensionMsg_TabConnectionInfo;

namespace base {

class DictionaryValue;

@@ -46,7 +47,7 @@ class MessagingBindings {

static void DispatchOnConnect(const ScriptContextSet& context_set,

int target_port_id,

const std::string& channel_name,

- const base::DictionaryValue& source_tab,

+ const ExtensionMsg_TabConnectionInfo& source,

const ExtensionMsg_ExternalConnectionInfo& info,

const std::string& tls_channel_id,

content::RenderView* restrict_to_render_view);