Add frameId to MessageSender (extension messaging API)

chrome/test/data/extensions/api_test/messaging/connect/page.js

Index: chrome/test/data/extensions/api_test/messaging/connect/page.js
diff --git a/chrome/test/data/extensions/api_test/messaging/connect/page.js b/chrome/test/data/extensions/api_test/messaging/connect/page.js
index 1e3a7e8eb3dcc68b0c9b3f2f7ba8204ef1819a7a..4563a3c8d80075f2671ac73f867e54db31d9bd3c 100644
--- a/chrome/test/data/extensions/api_test/messaging/connect/page.js
+++ b/chrome/test/data/extensions/api_test/messaging/connect/page.js
@@ -29,6 +29,8 @@ chrome.runtime.onConnect.addListener(function(port) {
       testPostMessageFromTab(port);
     } else if (msg.testSendMessageFromTab) {
       testSendMessageFromTab();
+    } else if (msg.testSendMessageFromFrame) {
+      testSendMessageFromFrame();
     } else if (msg.testDisconnect) {
       port.disconnect();
     } else if (msg.testDisconnectOnClose) {
@@ -65,6 +67,19 @@ function testSendMessageFromTab() {
   });
 }
 
+function testSendMessageFromFrame() {
+  // Add two frames. The content script declared in manifest.json (frame.js)
+  // runs in frames whose URL matches ?testSendMessageFromFrame.
+  // frame.js sends a message to the background page, which checks that
+  // sender.frameId exists and is different for both frames.
+  var f = document.createElement('iframe');
+  f.src = '?testSendMessageFromFrame';
+  document.body.appendChild(f);
+  f = document.createElement('iframe');
+  f.src = '?testSendMessageFromFrame';
+  document.body.appendChild(f);

[not at google - send to devlin, 2014/11/11 01:00:56]

Less duplication:

var createIframe(src) {
  var f = document.createElement('iframe');
  f.src = src;
  return src;
};
document.body.appendChild(createIframe('?testSendMessageFromFrame'));
document.body.appendChild(createIframe('?testSendMessageFromFrame'));

and I even suppose you could put that '?testSendMessageFromFrame' string inside
the createIframe function.

[robwu, 2014/11/11 21:32:47]

De-duplicated with a loop (which also gives unique names).

+}
+
 // Tests sendMessage to an invalid extension.
 function testSendMessageFromTabError() {
   // try sending a request to a bad extension id