Add frameId to MessageSender (extension messaging API)

extensions/renderer/runtime_custom_bindings.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/runtime_custom_bindings.h"
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/values.h"
 #include "content/public/renderer/render_view.h"
@@ skipping 40 matching lines @@
   content::RenderView* renderview = context()->GetRenderView();
   if (!renderview)
     return;
 
   // The Javascript code should validate/fill the arguments.
   CHECK_EQ(args.Length(), 3);
   CHECK(args[0]->IsString() && args[1]->IsString() && args[2]->IsBoolean());
 
   ExtensionMsg_ExternalConnectionInfo info;
 
+  if (blink::WebFrame* webframe = context()->web_frame())
+    info.source_frame_id = !webframe->parent() ? 0 : renderview->GetRoutingID();
+  else
+    info.source_frame_id = -1;

[not at google - send to devlin, 2014/11/10 18:36:42]

You should be able to determine this on the browser, by pulling out the
RenderFrameHosts's routing ID or whatever.

[robwu, 2014/11/10 21:43:07]

I need to know whether the request originated from the main frame. This
information is readily available here, so I figured that putting the frameId
assignment here would be best.

[not at google - send to devlin, 2014/11/10 22:20:17]

I'm not totally sure what you mean here, but the browser can be trusted, the
renderer cannot. The browser knows about frame IDs, so that's where they should
originate.

[robwu, 2014/11/10 23:13:38]

Updated CL. I've added a new IPC message ExtensionMsg_TabConnectionInfo because
ExtensionMsg_DispatchOnConnect had already reached the maximum of 5 arguments,
and because source_tab and source_frame_id are strongly relayed.

+
   // For messaging APIs, hosted apps should be considered a web page so hide
   // its extension ID.
   const Extension* extension = context()->extension();
   if (extension && !extension->is_hosted_app())
     info.source_id = extension->id();
 
   info.target_id = *v8::String::Utf8Value(args[0]->ToString());
   info.source_url = context()->GetURL();
   std::string channel_name = *v8::String::Utf8Value(args[1]->ToString());
   bool include_tls_channel_id =
@@ skipping 99 matching lines @@
       v8::Local<v8::Value> window = context->Global();
       DCHECK(!window.IsEmpty());
       v8_views->Set(v8::Integer::New(args.GetIsolate(), v8_index++), window);
     }
   }
 
   args.GetReturnValue().Set(v8_views);
 }
 
 }  // namespace extensions