Add frameId to MessageSender (extension messaging API)

chrome/test/data/extensions/api_test/messaging/connect/page.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 JSON.parse = function() {
   return "JSON.parse clobbered by content script.";
 };
 
 JSON.stringify = function() {
   return "JSON.stringify clobbered by content script.";
@@ skipping 11 matching lines @@
 chrome.runtime.onConnect.addListener(function(port) {
   console.log('connected');
   port.onMessage.addListener(function(msg) {
     console.log('got ' + msg);
     if (msg.testPostMessage) {
       port.postMessage({success: true});
     } else if (msg.testPostMessageFromTab) {
       testPostMessageFromTab(port);
     } else if (msg.testSendMessageFromTab) {
       testSendMessageFromTab();
+    } else if (msg.testSendMessageFromFrame) {
+      testSendMessageFromFrame();
     } else if (msg.testDisconnect) {
       port.disconnect();
     } else if (msg.testDisconnectOnClose) {
       window.location = "about:blank";
     } else if (msg.testPortName) {
       port.postMessage({portName:port.name});
     } else if (msg.testSendMessageFromTabError) {
       testSendMessageFromTabError();
     } else if (msg.testConnectFromTabError) {
       testConnectFromTabError();
@@ skipping 16 matching lines @@
 // For test onMessage.
 function testSendMessageFromTab() {
   chrome.runtime.sendMessage({step: 1}, function(response) {
     if (response.nextStep) {
       console.log('testSendMessageFromTab sent');
       chrome.runtime.sendMessage({step: 2});
     }
   });
 }
 
+function testSendMessageFromFrame() {
+  var f = document.createElement('iframe');
+  f.src = '?frame_test';
+  document.body.appendChild(f);

[not at google - send to devlin, 2014/11/11 00:03:04]

Ideally you'd test with more than 1 frame.

[robwu, 2014/11/11 00:34:26]

Done.

+  // The test will continue in frame.js (a content script that runs at
+  // ?frame_test, declared in manifest.json).

[not at google - send to devlin, 2014/11/11 00:03:04]

A more useful comment would explain what the frame_test parameter is actually
used for; it's so that the content script matches the frame or something? Using
tabs.executeScript would be a nicer way to do that, though I suppose it's a bit
harder to get working due to race conditions.

In either case: while the arbitrarily named "frame_test" is ok, it might be nice
to name it after the test which is using it, so "testSendMessageFromFrame".

[robwu, 2014/11/11 00:34:26]

Done.

+}
+
 // Tests sendMessage to an invalid extension.
 function testSendMessageFromTabError() {
   // try sending a request to a bad extension id
   chrome.runtime.sendMessage("bad-extension-id", {m: 1}, function(response) {
     var success = (response === undefined && chrome.runtime.lastError);
     chrome.runtime.sendMessage({success: success});
   });
 }
 
 // Tests connecting to an invalid extension.
 function testConnectFromTabError() {
   var port = chrome.runtime.connect("bad-extension-id");
   port.onDisconnect.addListener(function() {
     var success = (chrome.runtime.lastError ? true : false);
     chrome.runtime.sendMessage({success: success});
   });
 }
 
 // For test sendMessage.
 chrome.runtime.onMessage.addListener(function(request, sender, sendResponse) {
   chrome.test.assertEq({id: chrome.runtime.id}, sender);
   sendResponse({success: (request.step2 == 1)});
 });