Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1448)

Unified Diff: media/mojo/services/BUILD.gn

Issue 709923003: Use ApplicationTestBase for MojoRendererTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Works with https://codereview.chromium.org/710403002/ Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/mojo/services/BUILD.gn
diff --git a/media/mojo/services/BUILD.gn b/media/mojo/services/BUILD.gn
index 018745cb618a325eafdc96aacd864b4223036d28..5e8f91d72a798e1ee8469150d9a8b98ed2da368e 100644
--- a/media/mojo/services/BUILD.gn
+++ b/media/mojo/services/BUILD.gn
@@ -92,21 +92,26 @@ test("mojo_media_lib_unittests") {
]
}
-# GYP version: media/media.gyp:mojo_media_renderer_apptest
# Not a 'test' because this is loaded via mojo_shell as an app.
-shared_library("renderer_apptest") {
+# To run the test:
+# out/Debug/mojo_shell mojo:mojo_media_renderer_apptest
+# You may need to get "mojo_shell" from a mojo checkout and symlink all required
+# libraries.
+# Note that there's no GYP version for this test because ApplicationTestBase
msw 2014/11/11 23:36:38 I guess this should be a TODO? I can work on this
xhwang 2014/11/12 00:29:08 Added TODO, but not a priority for us.
+# doesn't work with gyp yet.
+shared_library("media_renderer_apptest") {
testonly = true
output_name = "mojo_media_renderer_apptest"
deps = [
"//base",
- "//base/test:test_support",
"//media",
"//media:shared_memory_support",
"//media/mojo/interfaces",
- "//mojo/common",
"//mojo/application",
- "//testing/gtest",
+ "//mojo/application:test_support",
+ "//mojo/common",
+ "//mojo/environment:chromium",
":renderer_impl_lib",
":renderer_app",
":lib",
@@ -114,7 +119,7 @@ shared_library("renderer_apptest") {
]
sources = [
- "renderer_unittest.cc",
+ "media_renderer_apptest.cc",
]
}
@@ -130,6 +135,6 @@ group("tests") {
testonly = true
deps = [
":mojo_media_lib_unittests",
- ":renderer_apptest",
+ ":media_renderer_apptest",
]
}

Powered by Google App Engine
This is Rietveld 408576698