expect_tests/test/data/package1/file1_test.py - Issue 709853003: New expect_tests UI

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: expect_tests/test/data/package1/file1_test.py

Issue 709853003: New expect_tests UI (Closed) Base URL: https://chromium.googlesource.com/infra/testing/expect_tests@shebang

Patch Set: Filtering on the CLI works. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 import unittest
	agable 2014/11/12 03:15:10 It's not clear why file1_test has an actual file1 It's not clear why file1_test has an actual file1 which it is testing, but file2_test doesn't. I think because all of this test data is divorced from the tests that are using it, it would be good to copiously comment these files so readers can easily refer back into the tests that use them. pgervais 2014/11/13 00:28:27 It was not clear to me either until you asked: I s Show quoted text On 2014/11/12 03:15:10, agable wrote: > It's not clear why file1_test has an actual file1 which it is testing, but > file2_test doesn't. > It was not clear to me either until you asked: I should put a unittest.TestCase in file1.py to make sure it is not detected. Originally, the purpose was to test the coverage functions, but I think I'll give up on that. Show quoted text > I think because all of this test data is divorced from the tests that are using > it, it would be good to copiously comment these files so readers can easily > refer back into the tests that use them. Will do, though it will get out of sync pretty quickly.
	2

	3 class File1Test(unittest.TestCase):

	4 def test_trivial_1(self):

	5 self.assertTrue(True)

OLD	NEW