expect_tests/test/data/other/README - Issue 709853003: New expect_tests UI

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: expect_tests/test/data/other/README

Issue 709853003: New expect_tests UI (Closed) Base URL: https://chromium.googlesource.com/infra/testing/expect_tests@shebang

Patch Set: Filtering on the CLI works. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« expect_tests/test/data/.expect_tests.cfg ('K') | « expect_tests/test/data/ignored/__init__.py ('k') | expect_tests/test/data/other/package1/__init__.py » ('j') | expect_tests/test/data/package1/file1_test.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 This directory should just contain package, and should not be a package
	agable 2014/11/12 03:15:10 Perhaps include more information here (or in test/ Perhaps include more information here (or in test/data/README) about what these files are actually for and why they shouldn't be touched. An alternative approach would be to describe this filesystem in the tests, and instantiate the whole filesystem in a temp directory at test time. That's what the depot_tools tests do. On the one hand, it's pretty cool. On the other hand, it means encoding the contents of all of these files inside the test files. And that sucks a lot. So I think this is the better solution, but it's something to consider. pgervais 2014/11/13 00:28:27 Having a read-only structure checked out with the Show quoted text On 2014/11/12 03:15:10, agable wrote: > Perhaps include more information here (or in test/data/README) about what these > files are actually for and why they shouldn't be touched. > > An alternative approach would be to describe this filesystem in the tests, and > instantiate the whole filesystem in a temp directory at test time. That's what > the depot_tools tests do. On the one hand, it's pretty cool. On the other hand, > it means encoding the contents of all of these files inside the test files. And > that sucks a lot. So I think this is the better solution, but it's something to > consider. Having a read-only structure checked out with the code means you never run into issues like files impossible to remove or non-writable directories. Beside, it's easier to debug when you have the actual directory structure to look at. I'll add more info in test/data/README.
	2 itself. It should NOT contain a __init__.py file.

OLD	NEW