chrome/browser/resources/pdf/pdf_extension_test.cc - Issue 709813004: Remove the deprecated function ExtensionService::extensions().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/pdf_extension_test.cc

Issue 709813004: Remove the deprecated function ExtensionService::extensions(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed thestig@'s comments. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/pepper/pepper_isolated_file_system_message_filter.cc ('k') | chrome/browser/supervised_user/supervised_user_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/pdf/pdf_extension_test.cc

diff --git a/chrome/browser/resources/pdf/pdf_extension_test.cc b/chrome/browser/resources/pdf/pdf_extension_test.cc

index bdfea3596053a9644078713313d0abb6e9bd92b2..01245ac4c6831bf6fa75e6b7a784bf7d05bd0dff 100644

--- a/chrome/browser/resources/pdf/pdf_extension_test.cc

+++ b/chrome/browser/resources/pdf/pdf_extension_test.cc

@@ -13,6 +13,7 @@

#include "chrome/common/extensions/manifest_handlers/mime_types_handler.h"

#include "chrome/test/base/ui_test_utils.h"

#include "content/public/test/browser_test_utils.h"

+#include "extensions/browser/extension_registry.h"

#include "extensions/test/result_catcher.h"

#include "grit/browser_resources.h"

#include "net/test/embedded_test_server/embedded_test_server.h"

@@ -51,7 +52,9 @@ class PDFExtensionTest : public ExtensionApiTest {

service->component_loader()->Add(IDR_PDF_MANIFEST,

base::FilePath(FILE_PATH_LITERAL("pdf")));

const extensions::Extension* extension =

- service->extensions()->GetByID("mhjfbmdgcfjbbpaeojofohoefgiehjai");

+ extensions::ExtensionRegistry::Get(profile())

+ ->enabled_extensions()

+ .GetByID("mhjfbmdgcfjbbpaeojofohoefgiehjai");

ASSERT_TRUE(extension);

ASSERT_TRUE(MimeTypesHandler::GetHandler(

extension)->CanHandleMIMEType("application/pdf"));