Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 709813003: Make landmines handle GN build directories better. (Closed)

Created:
6 years, 1 month ago by brettw
Modified:
6 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make landmines handle GN build directories better. GN has user-managed build output directories, and the build arguments are saved in those directories. This means that when you hit a landmine, the user will be forced to regenerate that build directory, and to respecify their build arguments. This change makes the landmine script look for GN build directories. If one is found, the build and command-line arguments to GN are preserved, and enough of a bootstrap build is left in that directory to regenerate itself the next time the build is run. This should make landmines transparent to GN users (except of course that everything will be rebuilt). Committed: https://crrev.com/f5b2cda7e05f7ffa4ac57b6a00d9cd52c1e0ac87 Cr-Commit-Position: refs/heads/master@{#303528}

Patch Set 1 #

Total comments: 1

Patch Set 2 : early return #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -1 line) Patch
M build/landmines.py View 1 2 chunks +74 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
brettw
6 years, 1 month ago (2014-11-10 19:20:28 UTC) #2
Dirk Pranke
lgtm w/ nit. https://codereview.chromium.org/709813003/diff/1/build/landmines.py File build/landmines.py (right): https://codereview.chromium.org/709813003/diff/1/build/landmines.py#newcode85 build/landmines.py:85: shutil.rmtree(build_dir) nit: I would early exit ...
6 years, 1 month ago (2014-11-10 22:14:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709813003/20001
6 years, 1 month ago (2014-11-10 22:23:54 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-10 23:08:14 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 23:09:02 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f5b2cda7e05f7ffa4ac57b6a00d9cd52c1e0ac87
Cr-Commit-Position: refs/heads/master@{#303528}

Powered by Google App Engine
This is Rietveld 408576698