Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: Source/bindings/core/v8/ScriptPromise.cpp

Issue 709743002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ExceptionState.cpp ('k') | Source/bindings/core/v8/V8ObjectConstructor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptPromise.cpp
diff --git a/Source/bindings/core/v8/ScriptPromise.cpp b/Source/bindings/core/v8/ScriptPromise.cpp
index 3f5d3df100860d472c28294c670f329e816f4c9d..f34d5b8ee62d08d3286d522382f6f62ecc3ad525 100644
--- a/Source/bindings/core/v8/ScriptPromise.cpp
+++ b/Source/bindings/core/v8/ScriptPromise.cpp
@@ -94,7 +94,7 @@ ScriptPromise::ScriptPromise(ScriptState* scriptState, v8::Handle<v8::Value> val
if (!value->IsPromise()) {
m_promise = ScriptValue(scriptState, v8::Handle<v8::Value>());
- V8ThrowException::throwTypeError("the given value is not a Promise", scriptState->isolate());
+ V8ThrowException::throwTypeError(scriptState->isolate(), "the given value is not a Promise");
return;
}
m_promise = ScriptValue(scriptState, value);
« no previous file with comments | « Source/bindings/core/v8/ExceptionState.cpp ('k') | Source/bindings/core/v8/V8ObjectConstructor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698