Chromium Code Reviews

Unified Diff: Source/bindings/core/v8/ExceptionState.cpp

Issue 709743002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: Source/bindings/core/v8/ExceptionState.cpp
diff --git a/Source/bindings/core/v8/ExceptionState.cpp b/Source/bindings/core/v8/ExceptionState.cpp
index 775ea8779e23799630d2209d73c44678d341e01a..31d3777240ffed74f0553c6da041ef7be9184b8d 100644
--- a/Source/bindings/core/v8/ExceptionState.cpp
+++ b/Source/bindings/core/v8/ExceptionState.cpp
@@ -62,7 +62,7 @@ void ExceptionState::throwDOMException(const ExceptionCode& ec, const String& me
m_code = ec;
String processedMessage = addExceptionContext(message);
m_message = processedMessage;
- setException(V8ThrowException::createDOMException(ec, processedMessage, m_creationContext, m_isolate));
+ setException(V8ThrowException::createDOMException(m_isolate, ec, processedMessage, m_creationContext));
}
void ExceptionState::throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage)
@@ -74,7 +74,7 @@ void ExceptionState::throwSecurityError(const String& sanitizedMessage, const St
m_message = finalSanitized;
String finalUnsanitized = addExceptionContext(unsanitizedMessage);
- setException(V8ThrowException::createDOMException(SecurityError, finalSanitized, finalUnsanitized, m_creationContext, m_isolate));
+ setException(V8ThrowException::createDOMException(m_isolate, SecurityError, finalSanitized, finalUnsanitized, m_creationContext));
}
void ExceptionState::setException(v8::Handle<v8::Value> exception)
« no previous file with comments | « Source/bindings/core/v8/CustomElementConstructorBuilder.cpp ('k') | Source/bindings/core/v8/ScriptPromise.cpp » ('j') | no next file with comments »

Powered by Google App Engine