Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 709733003: [PUSH] Fix lifetime of the hasPermission callback in layout Tests. (Closed)

Created:
6 years, 1 month ago by Miguel Garcia
Modified:
6 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[PUSH] Fix lifetime of the hasPermission callback in layout Tests. The promise needs to be created before calling the client for layout tests to work, it does not seem to be an issue in real code. BUG=401424 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185049

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/modules/push_messaging/PushManager.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Miguel Garcia
6 years, 1 month ago (2014-11-10 16:02:51 UTC) #2
Michael van Ouwerkerk
lgtm
6 years, 1 month ago (2014-11-10 16:08:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709733003/1
6 years, 1 month ago (2014-11-10 16:32:00 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 17:49:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185049

Powered by Google App Engine
This is Rietveld 408576698