Add gclient hook to download SDK extras on bots.

build/download_sdk_extras.py

+#!/usr/bin/env python
+# Copyright (c) 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Script to download sdk/extras packages on the bots from google storage."""
+
+import os
+import subprocess
+import sys
+
+sys.path.insert(0, os.path.join(os.path.dirname(__file__), 'android'))
+from pylib import constants
+
+GSUTIL_PATH = os.path.join(os.path.dirname(__file__), os.pardir, os.pardir,
+    os.pardir, os.pardir, os.pardir, 'third_party', 'gsutil', 'gsutil')
+SDK_EXTRAS_BUCKET = 'gs://chrome-sdk-extras'
+SDK_EXTRAS_PATH = os.path.join(constants.ANDROID_SDK_ROOT, 'extras')
+
+
+def GetCmdOutputAndStatus(cmd_lst):
+  process = subprocess.Popen(cmd_lst, stdout=subprocess.PIPE)
+  stdout, _ = process.communicate()
+  return stdout, process.returncode
+
+def is_buildbot_checkout():
+  if not os.path.exists(GSUTIL_PATH):
+    return False
+  stdout, rc = GetCmdOutputAndStatus([GSUTIL_PATH, 'ls', SDK_EXTRAS_BUCKET])
+  # If successfully read bucket, then this must be a bot with permissions
+  return not rc
+
+def main(args):
+  if is_buildbot_checkout():
+    for arg in args[1:]:
+      package_bucket = '%s/%s' % (SDK_EXTRAS_BUCKET, arg)

[navabi, 2014/11/21 09:40:29]

list of packages to download into third_party/android_tools/sdk/extras/

+      cmd_lst = [GSUTIL_PATH, '-m', 'rsync', '-r', package_bucket,

[navabi, 2014/11/21 09:40:29]

This will require us to upgrade the gsutil used on the bots. Currently we use
gsutil version 3._ and it does not have the 'rsync' command. We would need to
upgrade to version gsutil 4.0 to do rsync.

We use rsync to save time when the bot already has the correct version of the
package(s). My local tests show that when the package is not in the sdk/extras/
directory it takes ~12 seconds to download. If it there it will take ~5.5
seconds.

This may still be too long, as it will mean an extra ~5.5 seconds for every
'gclient sync' on the bots. Note that developers will not suffer this time. When
not on a bot, download_sdk_extras.py will not take any time.

+                 SDK_EXTRAS_PATH]
+      stdout, rc = GetCmdOutputAndStatus(cmd_lst)
+    return rc
+  return 0
+
+
+if __name__ == '__main__':
+  sys.exit(main(sys.argv))