Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 70963003: IDL compiler: addEventListener, removeEventListener methods (Closed)

Created:
7 years, 1 month ago by Nils Barth (inactive)
Modified:
7 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: addEventListener, removeEventListener methods Last methods CL! (Still lots of cleanup, then on to interfaces.) Also: Renaming 'special' to 'exceptional' in comments, as 'special' has technical meaning in Web IDL (special operations, special keywords, etc.). BUG=239771 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161913

Patch Set 1 #

Total comments: 1

Patch Set 2 : Other test #

Total comments: 13

Patch Set 3 : Revised #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -42 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_types.py View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 2 2 chunks +32 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/TestObjectPython.idl View 1 2 8 chunks +19 lines, -11 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 2 2 chunks +4 lines, -8 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 1 2 6 chunks +78 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nils Barth (inactive)
Last methods CL! https://codereview.chromium.org/70963003/diff/1/Source/bindings/scripts/code_generator_v8.pm File Source/bindings/scripts/code_generator_v8.pm (left): https://codereview.chromium.org/70963003/diff/1/Source/bindings/scripts/code_generator_v8.pm#oldcode2311 Source/bindings/scripts/code_generator_v8.pm:2311: Blank lines causes problems in Python ...
7 years, 1 month ago (2013-11-13 06:15:59 UTC) #1
haraken
LGTM but we might want to refactor HiddenDependency code in a follow-up. https://codereview.chromium.org/70963003/diff/30001/Source/bindings/scripts/unstable/v8_types.py File Source/bindings/scripts/unstable/v8_types.py ...
7 years, 1 month ago (2013-11-13 08:33:53 UTC) #2
Nils Barth (inactive)
Thanks! * clarified the complex section, and * will look into refactoring HiddenDependency code in ...
7 years, 1 month ago (2013-11-13 11:33:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/70963003/80001
7 years, 1 month ago (2013-11-13 11:34:39 UTC) #4
haraken
https://codereview.chromium.org/70963003/diff/30001/Source/bindings/templates/methods.cpp File Source/bindings/templates/methods.cpp (right): https://codereview.chromium.org/70963003/diff/30001/Source/bindings/templates/methods.cpp#newcode99 Source/bindings/templates/methods.cpp:99: {% set lookup_type, pass_ref_ptr_handling, hidden_dependency_action = On 2013/11/13 11:33:29, ...
7 years, 1 month ago (2013-11-13 11:37:46 UTC) #5
commit-bot: I haz the power
Change committed as 161913
7 years, 1 month ago (2013-11-13 12:30:59 UTC) #6
Nils Barth (inactive)
https://codereview.chromium.org/70963003/diff/30001/Source/bindings/templates/methods.cpp File Source/bindings/templates/methods.cpp (right): https://codereview.chromium.org/70963003/diff/30001/Source/bindings/templates/methods.cpp#newcode99 Source/bindings/templates/methods.cpp:99: {% set lookup_type, pass_ref_ptr_handling, hidden_dependency_action = On 2013/11/13 11:37:46, ...
7 years, 1 month ago (2013-11-14 03:01:52 UTC) #7
haraken
https://codereview.chromium.org/70963003/diff/30001/Source/bindings/templates/methods.cpp File Source/bindings/templates/methods.cpp (right): https://codereview.chromium.org/70963003/diff/30001/Source/bindings/templates/methods.cpp#newcode99 Source/bindings/templates/methods.cpp:99: {% set lookup_type, pass_ref_ptr_handling, hidden_dependency_action = On 2013/11/14 03:01:53, ...
7 years, 1 month ago (2013-11-14 04:33:02 UTC) #8
Nils Barth (inactive)
7 years, 1 month ago (2013-11-14 05:47:20 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/70963003/diff/30001/Source/bindings/templates...
File Source/bindings/templates/methods.cpp (right):

https://codereview.chromium.org/70963003/diff/30001/Source/bindings/templates...
Source/bindings/templates/methods.cpp:119:
{{hidden_dependency_action}}HiddenDependency(info.Holder(), info[1],
{{v8_class_name}}::eventListenerCacheIndex, info.GetIsolate());
On 2013/11/14 04:33:02, haraken wrote:
> Regarding hidden dependency, kouhei-san might have thoughts about how to
> refactor. So you can ask him offline.

Thanks, will do!

Powered by Google App Engine
This is Rietveld 408576698