Source/core/rendering/RenderTextControlSingleLine.h - Issue 709613003: To ensure consistency between layouts, we need to reset any overriden top for centering the textfie…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTextControlSingleLine.h

Issue 709613003: To ensure consistency between layouts, we need to reset any overriden top for centering the textfie… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updates Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/positioned-input-text-cursor.html ('K') | « LayoutTests/fast/forms/positioned-input-text-cursor-expected.html ('k') | Source/core/rendering/RenderTextControlSingleLine.cpp » ('j') | Source/core/rendering/RenderTextControlSingleLine.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderTextControlSingleLine.h

diff --git a/Source/core/rendering/RenderTextControlSingleLine.h b/Source/core/rendering/RenderTextControlSingleLine.h

index 2c060fdcf19573b5071345ac62f0e3813ccc5f33..8f45e5ca7aca638a601bbaf855efce08f4f5799f 100644

--- a/Source/core/rendering/RenderTextControlSingleLine.h

+++ b/Source/core/rendering/RenderTextControlSingleLine.h

@@ -79,6 +79,7 @@ private:

bool m_shouldDrawCapsLockIndicator;

LayoutUnit m_desiredInnerEditorLogicalHeight;

+ bool m_hasOverridenInnerEditorLogicalTop;

};

DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderTextControlSingleLine, isTextField());