LayoutTests/fast/repaint/positioned-input-text-cursor-repaint.html - Issue 709613003: To ensure consistency between layouts, we need to reset any overriden top for centering the textfie…

Side by Side Diff: LayoutTests/fast/repaint/positioned-input-text-cursor-repaint.html

Issue 709613003: To ensure consistency between layouts, we need to reset any overriden top for centering the textfie… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/repaint/positioned-input-text-cursor-repaint-expected.html » ('j') | LayoutTests/fast/repaint/positioned-input-text-cursor-repaint-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	Julien - ping for review 2014/11/11 16:57:58 This test is not in the right directory: fast/repa This test is not in the right directory: fast/repaint is for invalidation tests. This should be in fast/forms/ pals 2014/11/12 13:29:08 Done. Show quoted text On 2014/11/11 16:57:58, Julien Chaffraix - PST wrote: > This test is not in the right directory: fast/repaint is for invalidation tests. > This should be in fast/forms/ Done.
	2 <script>

	3 var i = 0;

	4 var refreshIntervalId;

	5

	6 function repaintTest()

	7 {

	8 refreshIntervalId = setInterval(function(){moveInputElement();}, 10);
	Julien - ping for review 2014/11/11 16:57:58 setInterval is almost never a good solution. If setInterval is almost never a good solution. If you need to force a layout, just call document.body.offsetTop; pals 2014/11/12 13:29:08 The bug does not reproduce in case of fulllayout. Show quoted text On 2014/11/11 16:57:58, Julien Chaffraix - PST wrote: > setInterval is almost never a good solution. If you need to force a layout, > just call document.body.offsetTop; The bug does not reproduce in case of fulllayout. The logicalTop keeps accumulating overriden value in case of simplifiedLayout while centering the innerEditor. how to force a simplifiedLayout? Julien - ping for review 2014/11/19 01:13:27 simplifiedlayout is just a type of layout. You sho Show quoted text On 2014/11/12 13:29:08, sanjoy_pal wrote: > On 2014/11/11 16:57:58, Julien Chaffraix - PST wrote: > > setInterval is almost never a good solution. If you need to force a layout, > > just call document.body.offsetTop; > The bug does not reproduce in case of fulllayout. The logicalTop > keeps accumulating overriden value in case of simplifiedLayout while centering > the innerEditor. how to force a simplifiedLayout? simplifiedlayout is just a type of layout. You should be able to force it the same way you do a normal layout: document.body.offsetTop;
	9 }

	10

	11 function moveInputElement()

	12 {

	13 var input = document.getElementById('input');

	14 i++;

	15 input.style.left = i*10 + 'px';

	16 input.style.width = '200px';

	17 if (i >= 3) {

	18 clearInterval(refreshIntervalId);

	19 if (window.testRunner)

	20 testRunner.notifyDone();

	21 }

	22 }

	23

	24 if (window.testRunner)

	25 testRunner.waitUntilDone();

	26 window.onload = repaintTest();

	27 </script>

	28

	29 <style>

	30 input {

	31 position: absolute;

	32 top: 0;

	33 left: 0;

	34 height: 50px;

	35 }

	36 </style>

	37
	Julien - ping for review 2014/11/11 16:57:58 Tests should have a description of what they test Tests should have a description of what they test and the expect outcome (passing / failing expectations). pals 2014/11/12 13:29:08 Done. Show quoted text On 2014/11/11 16:57:58, Julien Chaffraix - PST wrote: > Tests should have a description of what they test and the expect outcome > (passing / failing expectations). Done.
	38 <input id="input" type="text" autofocus>

OLD	NEW