LayoutTests/fast/repaint/positioned-input-text-cursor-repaint-expected.html - Issue 709613003: To ensure consistency between layouts, we need to reset any overriden top for centering the textfie…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/repaint/positioned-input-text-cursor-repaint-expected.html

Issue 709613003: To ensure consistency between layouts, we need to reset any overriden top for centering the textfie… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/repaint/positioned-input-text-cursor-repaint.html ('K') | « LayoutTests/fast/repaint/positioned-input-text-cursor-repaint.html ('k') | LayoutTests/platform/linux/fast/repaint/change-text-content-and-background-color-expected.txt » ('j') | Source/core/rendering/RenderTextControlSingleLine.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	Julien - ping for review 2014/11/11 16:57:58 If you only want to measure layout-related propert If you only want to measure layout-related properties, you should do a check-layout.js test as the output is more readable, it's faster and less likely to shoot yourself in the foot (ref-test only test what's in the viewport, anything else is ignored). pals 2014/11/12 13:29:08 I dont want to measure the layout-related properti Show quoted text On 2014/11/11 16:57:58, Julien Chaffraix - PST wrote: > If you only want to measure layout-related properties, you should do a > check-layout.js test as the output is more readable, it's faster and less likely > to shoot yourself in the foot (ref-test only test what's in the viewport, > anything else is ignored). I dont want to measure the layout-related properties. I want to test if the cursor is rendered out of the input field. Julien - ping for review 2014/11/19 01:13:27 The logical top is a layout-related property and t Show quoted text On 2014/11/12 13:29:08, sanjoy_pal wrote: > On 2014/11/11 16:57:58, Julien Chaffraix - PST wrote: > > If you only want to measure layout-related properties, you should do a > > check-layout.js test as the output is more readable, it's faster and less > likely > > to shoot yourself in the foot (ref-test only test what's in the viewport, > > anything else is ignored). > > I dont want to measure the layout-related properties. I want to test if the > cursor is rendered out of the input field. The logical top is a layout-related property and that's what you're fixing. ref-tests are OK but they have downsides and we should use check-layout.js tests as much as possible.
	2 <style>

	3 input {

	4 position: absolute;

	5 top: 0;

	6 left: 30px;

	7 height: 50px;

	8 width: 200px;

	9 }

	10 </style>

	11

	12 <input id="input" type="text">

	13 <script>

	14 document.getElementById('input').focus();

	15 </script>

OLD	NEW