Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: sky/engine/core/rendering/RenderBlockLineLayout.cpp

Issue 709603006: Remove a bunch of OS(MACOSX) code (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Even more Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/RenderBlockLineLayout.cpp
diff --git a/sky/engine/core/rendering/RenderBlockLineLayout.cpp b/sky/engine/core/rendering/RenderBlockLineLayout.cpp
index 9c10a78de48e00c19af0231193e1d0b0b500eec3..376a34f7440fb478e2fa3bc87819a0f90ca87038 100644
--- a/sky/engine/core/rendering/RenderBlockLineLayout.cpp
+++ b/sky/engine/core/rendering/RenderBlockLineLayout.cpp
@@ -363,13 +363,7 @@ static inline void setLogicalWidthForTextRun(RootInlineBox* lineBox, BidiRun* ru
bool kerningIsEnabled = font.fontDescription().typesettingFeatures() & Kerning;
-#if OS(MACOSX)
- // FIXME: Having any font feature settings enabled can lead to selection gaps on
- // Chromium-mac. https://bugs.webkit.org/show_bug.cgi?id=113418
- bool canUseSimpleFontCodePath = renderer->canUseSimpleFontCodePath() && !font.fontDescription().featureSettings();
-#else
bool canUseSimpleFontCodePath = renderer->canUseSimpleFontCodePath();
-#endif
// Since we don't cache glyph overflows, we need to re-measure the run if
// the style is linebox-contain: glyph.

Powered by Google App Engine
This is Rietveld 408576698