Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py

Issue 709603005: Limit the layout_test batch size for *SAN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py b/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
index 94d7b2cfed05d9f86e83c3aa094c8c76c74d3ab9..d79f89a97bde0a4435188ec544780b42742f9424 100644
--- a/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
+++ b/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
@@ -129,9 +129,17 @@ class PortTestCase(unittest.TestCase):
test_run_results.UNEXPECTED_ERROR_EXIT_STATUS)
finally:
out, err, logs = oc.restore_output()
- self.assertIn('pretty patches', logs) # And, hereere we should get warnings about both.
+ self.assertIn('pretty patches', logs) # And, here we should get warnings about both.
self.assertIn('build requirements', logs)
+ def test_default_batch_size(self):
+ port = self.make_port()
+
+ # Test that we set a finite batch size for sanitizer builds.
+ port._options.enable_sanitizer = True
+ sanitized_batch_size = port.default_batch_size()
+ self.assertIsNotNone(sanitized_batch_size)
+
def test_default_child_processes(self):
port = self.make_port()
num_workers = port.default_child_processes()
« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/port/base.py ('k') | Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698