Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 709593003: Change settings string controlling user add from user manager (Closed)

Created:
6 years, 1 month ago by Mike Lerman
Modified:
6 years, 1 month ago
Reviewers:
Marc Treib
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change settings string controlling user add from user manager BUG=431155 NOTRY=true Committed: https://crrev.com/e97c60fe5395ed93e751be10ca97be8e0ef5ae34 Cr-Commit-Position: refs/heads/master@{#303211}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mike Lerman
Hi Marc, Can I get a quick code review? Thanks! Mike
6 years, 1 month ago (2014-11-07 01:59:14 UTC) #2
Marc Treib
On 2014/11/07 01:59:14, Mike Lerman wrote: > Hi Marc, > > Can I get a ...
6 years, 1 month ago (2014-11-07 09:06:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709593003/1
6 years, 1 month ago (2014-11-07 09:08:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-07 09:08:49 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 09:09:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e97c60fe5395ed93e751be10ca97be8e0ef5ae34
Cr-Commit-Position: refs/heads/master@{#303211}

Powered by Google App Engine
This is Rietveld 408576698