src/IceOperand.cpp - Issue 709533002: Subzero: Implement InstList in terms of llvm::ilist<> .

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceOperand.cpp

Issue 709533002: Subzero: Implement InstList in terms of llvm::ilist<> . (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Add a comment explaining the ilist traits specialization Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceOperand.cpp

diff --git a/src/IceOperand.cpp b/src/IceOperand.cpp

index 8cf181afff3f67927c941fa8d004e23bfc39b2d7..7870d180b0b5e6458999f3818ff774775ab0726f 100644

--- a/src/IceOperand.cpp

+++ b/src/IceOperand.cpp

@@ -347,7 +347,8 @@ void VariablesMetadata::addNode(CfgNode *Node) {

}

- for (Inst *I : Node->getInsts()) {

+ for (auto I = Node->getInsts().begin(), E = Node->getInsts().end(); I != E;

+ ++I) {

if (I->isDeleted())

continue;

// Note: The implicit definitions (and uses) from InstFakeKill are

« no previous file with comments | « src/IceInst.h ('k') | src/IceTargetLowering.h » ('j') | no next file with comments »