Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Side by Side Diff: src/IceInst.h

Issue 709533002: Subzero: Implement InstList in terms of llvm::ilist<> . (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Add a comment explaining the ilist traits specialization Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/IceDefs.h ('k') | src/IceOperand.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 //===- subzero/src/IceInst.h - High-level instructions ----------*- C++ -*-===// 1 //===- subzero/src/IceInst.h - High-level instructions ----------*- C++ -*-===//
2 // 2 //
3 // The Subzero Code Generator 3 // The Subzero Code Generator
4 // 4 //
5 // This file is distributed under the University of Illinois Open Source 5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details. 6 // License. See LICENSE.TXT for details.
7 // 7 //
8 //===----------------------------------------------------------------------===// 8 //===----------------------------------------------------------------------===//
9 // 9 //
10 // This file declares the Inst class and its target-independent 10 // This file declares the Inst class and its target-independent
(...skipping 16 matching lines...) Expand all
27 // Most of the validity checking will be done in the bitcode reader. 27 // Most of the validity checking will be done in the bitcode reader.
28 // We need a list of everything that should be validated, and tests 28 // We need a list of everything that should be validated, and tests
29 // for each. 29 // for each.
30 30
31 namespace Ice { 31 namespace Ice {
32 32
33 // Base instruction class for ICE. Inst has two subclasses: 33 // Base instruction class for ICE. Inst has two subclasses:
34 // InstHighLevel and InstTarget. High-level ICE instructions inherit 34 // InstHighLevel and InstTarget. High-level ICE instructions inherit
35 // from InstHighLevel, and low-level (target-specific) ICE 35 // from InstHighLevel, and low-level (target-specific) ICE
36 // instructions inherit from InstTarget. 36 // instructions inherit from InstTarget.
37 class Inst { 37 class Inst : public llvm::ilist_node<Inst> {
38 Inst(const Inst &) = delete; 38 Inst(const Inst &) = delete;
39 Inst &operator=(const Inst &) = delete; 39 Inst &operator=(const Inst &) = delete;
40 40
41 public: 41 public:
42 enum InstKind { 42 enum InstKind {
43 // Arbitrary (alphabetical) order, except put Unreachable first. 43 // Arbitrary (alphabetical) order, except put Unreachable first.
44 Unreachable, 44 Unreachable,
45 Alloca, 45 Alloca,
46 Arithmetic, 46 Arithmetic,
47 Assign, // not part of LLVM/PNaCl bitcode 47 Assign, // not part of LLVM/PNaCl bitcode
(...skipping 783 matching lines...) Expand 10 before | Expand all | Expand 10 after
831 protected: 831 protected:
832 InstTarget(Cfg *Func, InstKind Kind, SizeT MaxSrcs, Variable *Dest) 832 InstTarget(Cfg *Func, InstKind Kind, SizeT MaxSrcs, Variable *Dest)
833 : Inst(Func, Kind, MaxSrcs, Dest) { 833 : Inst(Func, Kind, MaxSrcs, Dest) {
834 assert(Kind >= Target); 834 assert(Kind >= Target);
835 } 835 }
836 ~InstTarget() override {} 836 ~InstTarget() override {}
837 }; 837 };
838 838
839 } // end of namespace Ice 839 } // end of namespace Ice
840 840
841 // Override the default ilist traits so that Inst's private ctor and
842 // deleted dtor aren't invoked.
843 template <>
844 struct llvm::ilist_traits<Ice::Inst> : public llvm::ilist_default_traits<
845 Ice::Inst> {
846 Ice::Inst *createSentinel() const {
847 return static_cast<Ice::Inst *>(&Sentinel);
848 }
849 static void destroySentinel(Ice::Inst *) {}
850 Ice::Inst *provideInitialHead() const { return createSentinel(); }
851 Ice::Inst *ensureHead(Ice::Inst *) const { return createSentinel(); }
852 static void noteHead(Ice::Inst *, Ice::Inst *) {}
853 void deleteNode(Ice::Inst *) {}
854
855 private:
856 mutable ilist_half_node<Ice::Inst> Sentinel;
857 };
858
841 #endif // SUBZERO_SRC_ICEINST_H 859 #endif // SUBZERO_SRC_ICEINST_H
OLDNEW
« no previous file with comments | « src/IceDefs.h ('k') | src/IceOperand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698