Subzero: Implement InstList in terms of llvm::ilist<> .

src/IceCfg.cpp

 //===- subzero/src/IceCfg.cpp - Control flow graph implementation ---------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file implements the Cfg class, including constant pool
@@ skipping 300 matching lines @@
 }
 
 // Traverse every Variable of every Inst and verify that it
 // appears within the Variable's computed live range.
 bool Cfg::validateLiveness() const {
   TimerMarker T(TimerStack::TT_validateLiveness, this);
   bool Valid = true;
   Ostream &Str = Ctx->getStrDump();
   for (CfgNode *Node : Nodes) {
     Inst *FirstInst = NULL;
-    for (Inst *Inst : Node->getInsts()) {
+    for (auto Inst = Node->getInsts().begin(), E = Node->getInsts().end();
+         Inst != E; ++Inst) {
       if (Inst->isDeleted())
         continue;
       if (FirstInst == NULL)
         FirstInst = Inst;
       InstNumberT InstNumber = Inst->getNumber();
       if (Variable *Dest = Inst->getDest()) {
         if (!Dest->getIgnoreLiveness()) {
           bool Invalid = false;
           const bool IsDest = true;
           if (!Dest->getLiveRange().containsValue(InstNumber, IsDest))
             Invalid = true;
           // Check that this instruction actually *begins* Dest's live
           // range, by checking that Dest is not live in the previous
           // instruction.  As a special exception, we don't check this
           // for the first instruction of the block, because a Phi
           // temporary may be live at the end of the previous block,
           // and if it is also assigned in the first instruction of
           // this block, the adjacent live ranges get merged.
-          if (Inst != FirstInst && !Inst->isDestNonKillable() &&
+          if (static_cast<class Inst *>(Inst) != FirstInst &&
+              !Inst->isDestNonKillable() &&
               Dest->getLiveRange().containsValue(InstNumber - 1, IsDest))
             Invalid = true;
           if (Invalid) {
             Valid = false;
             Str << "Liveness error: inst " << Inst->getNumber() << " dest ";
             Dest->dump(this);
             Str << " live range " << Dest->getLiveRange() << "\n";
           }
         }
       }
@@ skipping 131 matching lines @@
     }
   }
   // Print each basic block
   for (CfgNode *Node : Nodes)
     Node->dump(this);
   if (getContext()->isVerbose(IceV_Instructions))
     Str << "}\n";
 }
 
 } // end of namespace Ice