Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 709523002: AX_ROLE_HORIZONTAL_RULE is not required. (Closed)

Created:
6 years, 1 month ago by shreeramk
Modified:
6 years, 1 month ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, extensions-reviews_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

AX_ROLE_HORIZONTAL_RULE is not required. There is already SplitterRole defined in blink, so better to remove HorizontalRuleRole from blink and return SplitterRole for hr tag. This patch makes the changes in chromium side. This CL would be followed by one blink CL which will remove the defined redundant role in blink side and one chromium CL after that to enable AX test and exposing correctly on MAC platform. BUG=384723 Committed: https://crrev.com/fc47ce190a01e2a5cb5a38a38303c53047839afc Cr-Commit-Position: refs/heads/master@{#303364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
M chrome/common/extensions/api/automation.idl View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/data/accessibility/hr.html View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/hr-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/ax_enums.idl View 1 chunk +0 lines, -1 line 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
shreeramk
PTAL. Thanks :)
6 years, 1 month ago (2014-11-07 03:51:00 UTC) #2
dmazzoni
lgtm
6 years, 1 month ago (2014-11-08 00:48:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709523002/1
6 years, 1 month ago (2014-11-08 00:49:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-08 02:52:35 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-08 02:54:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc47ce190a01e2a5cb5a38a38303c53047839afc
Cr-Commit-Position: refs/heads/master@{#303364}

Powered by Google App Engine
This is Rietveld 408576698