Issue 709423003: Reland "[turbofan] Fix select lowering" with fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 709423003: Reland "[turbofan] Fix select lowering" with fix. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer

Modified:
6 years, 1 month ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Reland "[turbofan] Fix select lowering" with fix. Select lowering must not merge Select nodes that depend on each other, because the resulting graph is not schedulable. TEST=unittests R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25245

Patch Set 1 #

Total comments: 2

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -15 lines)			Patch
M	src/compiler/node.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/compiler/select-lowering.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/compiler/select-lowering.cc	View	1 chunk	+46 lines, -11 lines	2 comments	Download
M	test/unittests/compiler/select-lowering-unittest.cc	View	3 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jarin

lgtm. https://codereview.chromium.org/709423003/diff/1/src/compiler/select-lowering.cc File src/compiler/select-lowering.cc (right): https://codereview.chromium.org/709423003/diff/1/src/compiler/select-lowering.cc#newcode67 src/compiler/select-lowering.cc:67: BoolVector queued(graph()->NodeCount(), false, &zone); Please, rename to 'visited'. ...

6 years, 1 month ago (2014-11-10 11:52:15 UTC) #2

Benedikt Meurer

Committed patchset #1 (id:1) manually as 25245 (presubmit successful).

6 years, 1 month ago (2014-11-10 11:55:31 UTC) #3

Benedikt Meurer

6 years, 1 month ago (2014-11-10 11:55:33 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/709423003/diff/1/src/compiler/select-lowering.cc
File src/compiler/select-lowering.cc (right):

https://codereview.chromium.org/709423003/diff/1/src/compiler/select-lowering...
src/compiler/select-lowering.cc:67: BoolVector queued(graph()->NodeCount(),
false, &zone);
On 2014/11/10 11:52:15, jarin wrote:
> Please, rename to 'visited'. 'queued' seems to imply that it is set iff the
node
> is in the queue.

Done.

Expand Messages | Collapse Messages