Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 709423002: DevTools: remove old Timeline front-end implementation (Closed)

Created:
6 years, 1 month ago by yurys
Modified:
6 years, 1 month ago
Reviewers:
caseq, alph, pfeldman, loislo
CC:
blink-reviews, shans, apavlov+blink_chromium.org, rjwright, Steve Block, caseq+blink_chromium.org, aandrey+blink_chromium.org, pfeldman+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, dstockwell, Timothy Loh, devtools-reviews_chromium.org, Eric Willigers, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, blink-reviews-animation_chromium.org, vsevik+blink_chromium.org, Mike Lawther (Google), sergeyv+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: remove old Timeline front-end implementation Now that Timeline uses tracing as its back-end it is time to remove old front-end implementation. BUG=428700, 344238, 298188, 359961, 371276 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185035

Patch Set 1 #

Patch Set 2 : Updated LayoutTests/inspector/layers/layer-canvas-log.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -6750 lines) Patch
M LayoutTests/FlakyTests View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/SlowTests View 2 chunks +0 lines, -7 lines 0 comments Download
M LayoutTests/TestExpectations View 3 chunks +0 lines, -7 lines 0 comments Download
M LayoutTests/VirtualTestSuites View 2 chunks +0 lines, -11 lines 0 comments Download
M LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/inspector/timeline-test.js View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/http/tests/inspector/timeline-xhr-event.html View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/http/tests/inspector/timeline-xhr-event-expected.txt View 1 chunk +0 lines, -56 lines 0 comments Download
D LayoutTests/http/tests/inspector/timeline-xhr-response-type-blob-event.html View 1 chunk +0 lines, -49 lines 0 comments Download
D LayoutTests/http/tests/inspector/timeline-xhr-response-type-blob-event-expected.txt View 1 chunk +0 lines, -54 lines 0 comments Download
D LayoutTests/http/tests/inspector/websocket/timeline-websocket-event.html View 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/http/tests/inspector/websocket/timeline-websocket-event-expected.txt View 1 chunk +0 lines, -50 lines 0 comments Download
D LayoutTests/inspector/console/console-timeline.html View 1 chunk +0 lines, -247 lines 0 comments Download
D LayoutTests/inspector/console/console-timeline-expected.txt View 1 chunk +0 lines, -98 lines 0 comments Download
M LayoutTests/inspector/layers/layer-canvas-log.html View 1 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/inspector/timeline/anonymous-image-object.html View 1 chunk +0 lines, -43 lines 0 comments Download
D LayoutTests/inspector/timeline/anonymous-image-object-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/inspector/timeline/category-filter.html View 1 chunk +0 lines, -61 lines 0 comments Download
D LayoutTests/inspector/timeline/category-filter-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/inspector/timeline/resources/anImage.png View Binary file 0 comments Download
D LayoutTests/inspector/timeline/resources/anotherImage.png View Binary file 0 comments Download
D LayoutTests/inspector/timeline/resources/big.png View Binary file 0 comments Download
D LayoutTests/inspector/timeline/resources/test.bmp View Binary file 0 comments Download
D LayoutTests/inspector/timeline/resources/test.gif View Binary file 0 comments Download
D LayoutTests/inspector/timeline/resources/test.ico View Binary file 0 comments Download
D LayoutTests/inspector/timeline/resources/test.jpg View Binary file 0 comments Download
D LayoutTests/inspector/timeline/resources/test.png View Binary file 0 comments Download
D LayoutTests/inspector/timeline/resources/test.webp View Binary file 0 comments Download
D LayoutTests/inspector/timeline/resources/timeline-data.js View 1 chunk +0 lines, -181 lines 0 comments Download
D LayoutTests/inspector/timeline/resources/timeline-iframe-data.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/inspector/timeline/resources/timeline-iframe-paint.html View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-animation-frame.html View 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-animation-frame-expected.txt View 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-auto-record.html View 1 chunk +0 lines, -51 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-auto-record-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-bound-function.html View 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-bound-function-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-coalescing.html View 1 chunk +0 lines, -113 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-coalescing-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-compatibility.html View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-compatibility-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-decode-resize.html View 1 chunk +0 lines, -82 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-decode-resize-expected.txt View 1 chunk +0 lines, -88 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-dfs.html View 1 chunk +0 lines, -53 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-dfs-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-dom-content-loaded-event.html View 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-dom-content-loaded-event-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-enum-stability.html View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt View 1 chunk +0 lines, -54 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-event-dispatch.html View 1 chunk +0 lines, -43 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-event-dispatch-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-filtering.html View 1 chunk +0 lines, -100 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-filtering-expected.txt View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-frame-model.html View 1 chunk +0 lines, -202 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-frame-model-expected.txt View 1 chunk +0 lines, -226 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-gc-event.html View 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-gc-event-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-injected-script-eval.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-injected-script-eval-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-layer-tree-snapshot.html View 1 chunk +0 lines, -80 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-layer-tree-snapshot-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-layout.html View 1 chunk +0 lines, -55 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-layout-expected.txt View 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-layout-reason.html View 1 chunk +0 lines, -50 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-layout-reason-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-load.html View 1 chunk +0 lines, -95 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-load-event.html View 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-load-event-expected.txt View 1 chunk +0 lines, -50 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-load-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-mark-timeline.html View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-mark-timeline-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-network-received-data.html View 1 chunk +0 lines, -57 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-network-received-data-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-network-resource.html View 1 chunk +0 lines, -96 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-network-resource.js View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-network-resource-expected.txt View 1 chunk +0 lines, -45 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-node-reference.html View 1 chunk +0 lines, -78 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-node-reference-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-paint.html View 1 chunk +0 lines, -70 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-paint-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-parse-html.html View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-parse-html-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-recalculate-styles.html View 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-recalculate-styles-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-receive-response-event.html View 1 chunk +0 lines, -64 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-receive-response-event-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-records-cleared.html View 1 chunk +0 lines, -47 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-records-cleared-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-script-id.html View 1 chunk +0 lines, -63 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-script-id-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-script-tag-1.html View 1 chunk +0 lines, -60 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-script-tag-1-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-script-tag-2.html View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-script-tag-2.js View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/inspector/timeline/timeline-script-tag-2-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-time.html View 1 chunk +0 lines, -97 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-time-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-time-stamp.html View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-time-stamp-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-timer.html View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-timer-expected.txt View 1 chunk +0 lines, -132 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-timer-fired-from-eval-call-site.html View 1 chunk +0 lines, -58 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-timer-fired-from-eval-call-site-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-trivial.html View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-trivial-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-window-filter.html View 1 chunk +0 lines, -129 lines 0 comments Download
D LayoutTests/inspector/timeline/timeline-window-filter-expected.txt View 1 chunk +0 lines, -55 lines 0 comments Download
D LayoutTests/inspector/timeline/trace-event-self-time.html View 1 chunk +0 lines, -208 lines 0 comments Download
D LayoutTests/inspector/timeline/trace-event-self-time-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M LayoutTests/inspector/tracing/decode-resize.html View 1 chunk +7 lines, -7 lines 0 comments Download
M LayoutTests/inspector/tracing/decode-resize-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
D LayoutTests/virtual/deferred/inspector/timeline/README.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/virtual/deferred/inspector/timeline/timeline-decode-resize-expected.txt View 1 chunk +0 lines, -88 lines 0 comments Download
D LayoutTests/virtual/deferred/inspector/timeline/timeline-paint-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/virtual/implsidepainting/inspector/timeline/README.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/virtual/implsidepainting/inspector/timeline/timeline-decode-resize-expected.txt View 1 chunk +0 lines, -82 lines 0 comments Download
D LayoutTests/virtual/implsidepainting/inspector/timeline/timeline-frames.html View 1 chunk +0 lines, -65 lines 0 comments Download
D LayoutTests/virtual/implsidepainting/inspector/timeline/timeline-frames-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/virtual/implsidepainting/inspector/timeline/timeline-paint-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
M Source/devtools/devtools.gypi View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/devtools/front_end/sdk/Target.js View 2 chunks +1 line, -5 lines 0 comments Download
D Source/devtools/front_end/sdk/TimelineManager.js View 1 chunk +0 lines, -170 lines 0 comments Download
M Source/devtools/front_end/sdk/module.json View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineFrameModel.js View 2 chunks +0 lines, -153 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 1 chunk +0 lines, -38 lines 0 comments Download
D Source/devtools/front_end/timeline/TimelineModelImpl.js View 1 chunk +0 lines, -668 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 11 chunks +25 lines, -57 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 chunk +1 line, -1 line 0 comments Download
D Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js View 1 chunk +0 lines, -682 lines 0 comments Download
M Source/devtools/front_end/timeline/module.json View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yurys
6 years, 1 month ago (2014-11-10 10:40:37 UTC) #2
alph
lgtm
6 years, 1 month ago (2014-11-10 11:28:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709423002/1
6 years, 1 month ago (2014-11-10 12:36:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709423002/20001
6 years, 1 month ago (2014-11-10 12:45:39 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 13:48:09 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 185035

Powered by Google App Engine
This is Rietveld 408576698