Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 709363002: Revert of Revert of Fix RemoteFrame detachment to signal its client. (Closed)

Created:
6 years, 1 month ago by raymes
Modified:
6 years, 1 month ago
Reviewers:
kenrb, Nate Chapin, dcheng
CC:
blink-reviews, dglazkov+blink, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Revert of Fix RemoteFrame detachment to signal its client. (patchset #1 id:1 of https://codereview.chromium.org/699053004/) Reason for revert: Reverting the revert. This turned out not to be the cause of https://code.google.com/p/chromium/issues/detail?id=431608 Original issue's description: > Revert of Fix RemoteFrame detachment to signal its client. (patchset #1 id:1 of https://codereview.chromium.org/712653002/) > > Reason for revert: > Speculative revert to attempt to fix https://code.google.com/p/chromium/issues/detail?id=431608 > > Original issue's description: > > Fix RemoteFrame detachment to signal its client. > > > > We were seeing crashes in checkFrameCountConsistency() because during > > RemoteFrame detachment the client was not getting signalled to modify > > the frame tree, resulting in inconsistent state. This CL corrects that > > problem. > > > > BUG=430972 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184987 > > TBR=japhet@chromium.org,dcheng@chromium.org,kenrb@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=430972 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185015 TBR=japhet@chromium.org,dcheng@chromium.org,kenrb@chromium.org NOTREECHECKS=true NOTRY=true BUG=430972 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185018

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M Source/web/RemoteFrameClientImpl.cpp View 2 chunks +12 lines, -1 line 0 comments Download
M public/web/WebRemoteFrameClient.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
raymes
Created Revert of Revert of Fix RemoteFrame detachment to signal its client.
6 years, 1 month ago (2014-11-10 03:05:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709363002/1
6 years, 1 month ago (2014-11-10 03:06:25 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 03:06:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185018

Powered by Google App Engine
This is Rietveld 408576698