Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 709333003: Revert of Domain Reliability: Switch to BackoffEntry in Scheduler (Closed)

Created:
6 years, 1 month ago by raymes
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@parse_retry_after_header
Project:
chromium
Visibility:
Public.

Description

Revert of Domain Reliability: Switch to BackoffEntry in Scheduler (patchset #4 id:60001 of https://codereview.chromium.org/704893002/) Reason for revert: Speculative revert to attempt to fix https://code.google.com/p/chromium/issues/detail?id=431608 Original issue's description: > Domain Reliability: Switch to BackoffEntry in Scheduler > > Previously, Domain Reliability was using homegrown backoff handling code. > Switch to using the existing BackoffEntry. > > BUG= > > Committed: https://crrev.com/dd6819b1522473ae11b98cb60b8b613af01f4b56 > Cr-Commit-Position: refs/heads/master@{#303296} TBR=davidben@chromium.org,ttuttle@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/ff48ecc9a42f24889384503488208db7b495f549 Cr-Commit-Position: refs/heads/master@{#303412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -77 lines) Patch
M components/domain_reliability/scheduler.h View 2 chunks +12 lines, -8 lines 0 comments Download
M components/domain_reliability/scheduler.cc View 8 chunks +39 lines, -39 lines 0 comments Download
M components/domain_reliability/scheduler_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/domain_reliability/util.h View 2 chunks +0 lines, -16 lines 0 comments Download
M components/domain_reliability/util.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
raymes
Created Revert of Domain Reliability: Switch to BackoffEntry in Scheduler
6 years, 1 month ago (2014-11-10 01:11:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709333003/1
6 years, 1 month ago (2014-11-10 01:12:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-10 01:13:26 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ff48ecc9a42f24889384503488208db7b495f549 Cr-Commit-Position: refs/heads/master@{#303412}
6 years, 1 month ago (2014-11-10 01:14:08 UTC) #4
raymes
6 years, 1 month ago (2014-11-10 03:07:56 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/681993003/ by raymes@chromium.org.

The reason for reverting is: This revert may have fixed this issue. Reverting to
see if the issue it re-appears without this..

Powered by Google App Engine
This is Rietveld 408576698