Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 709213002: Remove ContentData. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove ContentData. This was to support CSS generated content. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/34622368c4dd5065b7420131abc0c2a7e7979c95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -482 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 3 chunks +0 lines, -18 lines 0 comments Download
M sky/engine/core/css/CSSProperties.in View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/StylePropertySerializer.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.cpp View 2 chunks +0 lines, -64 lines 0 comments Download
M sky/engine/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +0 lines, -70 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResourceLoader.cpp View 2 chunks +0 lines, -14 lines 0 comments Download
M sky/engine/core/loader/ImageLoader.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderImage.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderImage.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/core/rendering/style/ContentData.h View 1 chunk +0 lines, -143 lines 0 comments Download
D sky/engine/core/rendering/style/ContentData.cpp View 1 chunk +0 lines, -66 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 3 chunks +0 lines, -10 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.cpp View 3 chunks +0 lines, -57 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.h View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.cpp View 4 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
ojan
lgtm
6 years, 1 month ago (2014-11-08 02:37:03 UTC) #2
esprehn
6 years, 1 month ago (2014-11-08 02:47:43 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
34622368c4dd5065b7420131abc0c2a7e7979c95.

Powered by Google App Engine
This is Rietveld 408576698