Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Unified Diff: sky/engine/wtf/ListHashSet.h

Issue 709203002: Remove more oilpan. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/platform/image-decoders/ImageDecoder.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/wtf/ListHashSet.h
diff --git a/sky/engine/wtf/ListHashSet.h b/sky/engine/wtf/ListHashSet.h
index 52b2906becfdcfe3026b9ffbaab3ba5ee5f68678..1b8515a5798642fe96ff4e1ae77e57d92ab34e1e 100644
--- a/sky/engine/wtf/ListHashSet.h
+++ b/sky/engine/wtf/ListHashSet.h
@@ -396,26 +396,6 @@ namespace WTF {
allocator->deallocate(this);
}
- // This is not called in normal tracing, but it is called if we find a
- // pointer to a node on the stack using conservative scanning. Since
- // the original ListHashSet may no longer exist we make sure to mark
- // the neighbours in the chain too.
- void trace(typename NodeAllocator::Visitor* visitor)
- {
- // The conservative stack scan can find nodes that have been
- // removed from the set and destructed. We don't need to trace
- // these, and it would be wrong to do so, because the class will
- // not expect the trace method to be called after the destructor.
- // It's an error to remove a node from the ListHashSet while an
- // iterator is positioned at that node, so there should be no valid
- // pointers from the stack to a destructed node.
- if (wasAlreadyDestructed())
- return;
- NodeAllocator::traceValue(visitor, this);
- visitor->mark(next());
- visitor->mark(prev());
- }
-
ListHashSetNode* next() const { return reinterpret_cast<ListHashSetNode*>(this->m_next); }
ListHashSetNode* prev() const { return reinterpret_cast<ListHashSetNode*>(this->m_prev); }
« no previous file with comments | « sky/engine/platform/image-decoders/ImageDecoder.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698